Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #22502 - Update "Jump back in" group's subtitle format #22506

Merged
merged 2 commits into from
Nov 22, 2021
+3 −3
Merged

For #22502 - Update "Jump back in" group's subtitle format #22506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af2ff6
For #22502 - Update "Jump back in" group's subtitle format
Mugurell Nov 19, 2021
fcefdf0
Merge branch 'main' into recentTabsText
mergify[bot] Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/org/mozilla/fenix/home/recenttabs/view/RecentTabs.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ private fun RecentSearchGroupItem(

Spacer(modifier = Modifier.width(8.dp))

RecentTabSubtitle(subtitle = stringResource(R.string.recent_tabs_search_term_count, count))
RecentTabSubtitle(subtitle = stringResource(R.string.recent_tabs_search_term_count_2, count))
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@
The first parameter is the search term that the user used. (for example: your search for "cat")-->
<string name="recent_tabs_search_term">Your search for \"%1$s\"</string>
<!-- Text for the number of tabs in a group in the 'Jump back in' section of the new tab
The first parameter is the count for number of sites in the group. This number will always be more than one. -->
<string name="recent_tabs_search_term_count">Sites: %1$s</string>
%d is a placeholder for the number of sites in the group. This number will always be more than one. -->
<string name="recent_tabs_search_term_count_2">%d sites</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Delphine @Mugurell I am wondering if this will break localization for Beta since we can't just remove a string like this iirc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, forgot about #20871.
Will add add the previous string back, thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #22572 to add back the previous string.


<!-- History Metadata -->
<!-- Header text for a section on the home screen that displays grouped highlights from the
Expand Down