This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #20634: remove some unused color resources #21244
Closed
RotBolt
wants to merge
4
commits into
mozilla-mobile:main
from
RotBolt:performance/#20634-remove-unused-resources-part-1
Closed
For #20634: remove some unused color resources #21244
RotBolt
wants to merge
4
commits into
mozilla-mobile:main
from
RotBolt:performance/#20634-remove-unused-resources-part-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
3 tasks
gabrielluong
previously requested changes
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove lint-baseline.xml
@gabrielluong I have not removed the |
mcomella
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you @RotBolt !
CI in #21273 |
gabrielluong
added
the
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
label
Sep 14, 2021
…ed-resources-part-1
gabrielluong
removed
the
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
label
Sep 14, 2021
jonalmeida
added
the
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
label
Sep 14, 2021
…ed-resources-part-1
Pushed another CI build that seems to have worked. |
Mergify took away the CI build status after it rebased. 😅 Let's just land the other PR in that case for now.. |
jonalmeida
removed
the
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
label
Sep 14, 2021
…ed-resources-part-1
Landed in #21282. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Tests: This PR includes thorough tests or an explanation of why it does not
Fixing issues from lint-baseline.xml. So not added any tests
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Fixing issues from lint-baseline.xml. So not added any screenshots
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.
To download an APK when reviewing a PR:
Partially closes #20634