Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #20634: remove some unused color resources #21244

Conversation

RotBolt
Copy link
Contributor

@RotBolt RotBolt commented Sep 11, 2021

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
    Fixing issues from lint-baseline.xml. So not added any tests

  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
    Fixing issues from lint-baseline.xml. So not added any screenshots

  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Partially closes #20634

@RotBolt RotBolt requested review from a team as code owners September 11, 2021 11:39
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@RotBolt
Copy link
Contributor Author

RotBolt commented Sep 11, 2021

Hello @mcomella
I have raised this PR to remove some of the unused resources
I have raised another PR for fixing some other issues from lint-baseline.xml here

Whichever gets merged first, I will rebase the other then

Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove lint-baseline.xml

@RotBolt
Copy link
Contributor Author

RotBolt commented Sep 13, 2021

Please don't remove lint-baseline.xml

@gabrielluong I have not removed the lint-baseline.xml. I regenerated the lint-baseline.xml due to which there were heavy editions
See its the same branch
Screenshot 2021-09-13 at 9 02 12 PM

Copy link
Contributor

@mcomella mcomella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you @RotBolt !

@mcomella mcomella mentioned this pull request Sep 13, 2021
3 tasks
@mcomella
Copy link
Contributor

CI in #21273

@gabrielluong gabrielluong dismissed their stale review September 14, 2021 02:43

don't need another review

@gabrielluong gabrielluong added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 14, 2021
@gabrielluong gabrielluong removed the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 14, 2021
@jonalmeida jonalmeida added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 14, 2021
@jonalmeida
Copy link
Contributor

CI in #21273

Pushed another CI build that seems to have worked.

@jonalmeida
Copy link
Contributor

Mergify took away the CI build status after it rebased. 😅

Let's just land the other PR in that case for now..

@jonalmeida jonalmeida removed the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 14, 2021
@jonalmeida
Copy link
Contributor

Landed in #21282.

@jonalmeida jonalmeida closed this Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove suppressed UnusedResources warnings in lint baseline file
4 participants