Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #20919 quit the app after removing a study. #20933

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Aug 19, 2021

The crash on #20919 was caused because the deleted experiment changed UI according with experiment details, but as we removed the experiment the UI was still there, causing an inconsistent state, as some part of the code know that were are not on a experiment but some part that were not reloaded still have the experiment UI, to avoid similar inconsistencies and be safe let's just quite the app and allow to everything start fresh.

java.lang.ClassCastException
	at org.mozilla.fenix.settings.SettingsFragment.updateMakeDefaultBrowserPreference(SettingsFragment.kt:500)
	at org.mozilla.fenix.settings.SettingsFragment.update(SettingsFragment.kt:230)
	at org.mozilla.fenix.settings.SettingsFragment.onResume(SettingsFragment.kt:174)
	at androidx.fragment.app.Fragment.performResume(Fragment.java:3039)
	at androidx.fragment.app.FragmentStateManager.resume(FragmentStateManager.java:607)
	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:306)
	at androidx.fragment.app.SpecialEffectsController$FragmentStateManagerOperation.complete(SpecialEffectsController.java:742)
	at androidx.fragment.app.SpecialEffectsController$Operation.completeSpecialEffect(SpecialEffectsController.java:669)
	at androidx.fragment.app.DefaultSpecialEffectsController$SpecialEffectsInfo.completeSpecialEffect(DefaultSpecialEffectsController.java:779)
	at androidx.fragment.app.DefaultSpecialEffectsController.startAnimations(DefaultSpecialEffectsController.java:239)
	at androidx.fragment.app.DefaultSpecialEffectsController.executeOperations(DefaultSpecialEffectsController.java:119)
	at androidx.fragment.app.SpecialEffectsController.executePendingOperations(SpecialEffectsController.java:294)
	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2202)
	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2106)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2002)
	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:524)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7682)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:516)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Amejia481 Amejia481 requested review from a team as code owners August 19, 2021 21:22
@Amejia481 Amejia481 changed the title For #20919 quite the after removing a study. For #20919 quite the app after removing a study. Aug 19, 2021
@Amejia481 Amejia481 changed the title For #20919 quite the app after removing a study. For #20919 quit the app after removing a study. Aug 19, 2021
@Amejia481 Amejia481 added the needs:review PRs that need to be reviewed label Aug 19, 2021
rocketsroger
rocketsroger previously approved these changes Aug 20, 2021
@rocketsroger rocketsroger removed the needs:review PRs that need to be reviewed label Aug 20, 2021
@Amejia481 Amejia481 added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 20, 2021
@mergify mergify bot merged commit d301998 into mozilla-mobile:main Aug 20, 2021
@Amejia481
Copy link
Contributor Author

@Mergifyio backport releases_v92.0.0

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2021

Command backport releases_v92.0.0: success

Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants