This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #19490 : Add event ping telemetry for the Baidu top site click #20705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
rxumoz
force-pushed
the
cn-master-topsiteBaiduTelemetry
branch
from
August 6, 2021 01:16
77445e2
to
4cbe5df
Compare
I believe this would need a request for data collection here. |
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
@travis79 Are you available for a data review on this? 🙏 |
Data Review
Yes, through the metrics.yaml file and through the Glean Dictionary.
Yes, through the "Send Usage Data" preference in the app settings.
N/A, collection set to end 2022-02-01.
Category 2, Interaction data
Default-on
No
Yes
No Resultdata-review+ |
rocketsroger
approved these changes
Aug 19, 2021
rxumoz
added
the
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
label
Aug 20, 2021
6 tasks
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event ping for Baidu topsite click