Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #19490 : Add event ping telemetry for the Baidu top site click #20705

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

rxumoz
Copy link
Contributor

@rxumoz rxumoz commented Aug 6, 2021

Add event ping for Baidu topsite click

@rxumoz rxumoz requested review from a team as code owners August 6, 2021 01:15
@rxumoz rxumoz linked an issue Aug 6, 2021 that may be closed by this pull request
7 tasks
@rxumoz rxumoz force-pushed the cn-master-topsiteBaiduTelemetry branch from 77445e2 to 4cbe5df Compare August 6, 2021 01:16
@jonalmeida
Copy link
Contributor

I believe this would need a request for data collection here.

@rxumoz rxumoz added the needs:data-review PR is awaiting a data review label Aug 9, 2021
@rxumoz
Copy link
Contributor Author

rxumoz commented Aug 9, 2021

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users click the top site of Baidu (default top site of MozillaOnline builds).
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:
  • Since Baidu is one of the main business partner of MozillaOnline builds, we need this to provide information essential for advancing business objectives.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A, similar event about google has already merged into code base.
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
  • All data is Category 2.
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • 2022-02-01 (same as open_google_search_attribution)
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled. Assuming mainly in China since the top site of Baidu is default in MozillaOnline builds which mainly used in China.
  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams & Beijing office colleagues.
  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? If so:
  • N/A.

@eliserichards
Copy link

@travis79 Are you available for a data review on this? 🙏

@travis79
Copy link
Member

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* How often users click the top site of Baidu (default top site of  MozillaOnline builds).


1. Why does Mozilla need to answer these questions?  Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:


* Since Baidu is one of the main business partner of MozillaOnline builds, we need this to provide information essential for advancing business objectives.


1. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* N/A, similar event about google has already merged into code base.


1. Can current instrumentation answer these questions?


* Currently there are no events to track this.


1. List all proposed measurements and indicate the category of data collection for each measurement, using the [Firefox data collection categories](https://wiki.mozilla.org/Data_Collection) found on the Mozilla wiki.


* All data is Category 2.


1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* This collection is documented in the Glean Dictionary at [dictionary.telemetry.mozilla.org](https://dictionary.telemetry.mozilla.org/)


1. How long will this data be collected?  Choose one of the following:


* 2022-02-01 (same as **open_google_search_attribution**)


1. What populations will you measure?


* All release, beta, and nightly users with telemetry enabled. Assuming mainly in China since the top site of Baidu is default in MozillaOnline builds which mainly used in China.


1. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


1. Please provide a general description of how you will analyze this data.


* Glean / Amplitude


1. Where do you intend to share the results of your analysis?


* Only on Glean, Amplitude and with mobile teams & Beijing office colleagues.


1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? If so:


* N/A.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and through the Glean Dictionary.

  1. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, through the "Send Usage Data" preference in the app settings.

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection set to end 2022-02-01.

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

Default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@travis79 travis79 removed the needs:data-review PR is awaiting a data review label Aug 13, 2021
@rxumoz rxumoz added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry]Fenix Baidu Search tile in MozillaOnline Builds
5 participants