-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #19923: renew telemetry probes #19924
For #19923: renew telemetry probes #19924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I believe @pocmo mentioned about getting too much telemetry spam so perhaps we should ping around and figure out an alternative to [email protected]
email. Ideally, I think we should just create a new email group for the telemetry owners.
This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏 |
|
0191182
to
a558b9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #19924 +/- ##
============================================
- Coverage 37.00% 37.00% -0.01%
Complexity 1653 1653
============================================
Files 542 542
Lines 21062 21062
Branches 3154 3154
============================================
- Hits 7795 7794 -1
Misses 12366 12366
- Partials 901 902 +1
Continue to review full report at Codecov.
|
Data Collection Renewal Review
Yes
Yes Resultdata-review+ |
app/metrics.yaml
Outdated
@@ -432,7 +432,7 @@ events: | |||
- interaction | |||
notification_emails: | |||
- [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this one 👻
a558b9d
to
8995c54
Compare
For #19923
Waiting on confirmation from Vesta✅ (see google doc)It's probably easier to review these commits separately so you can see the date changes apart from the email changes
downloads
,about_page
, orcontextual_hint.tracking_protection
in this PR. Separate issues are filed for these (1, 2, 3) to handle before July expirations.notification_emails
to [email protected]Pull Request checklist
To download an APK when reviewing a PR: