Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #19923: renew telemetry probes #19924

Merged

Conversation

eliserichards
Copy link

@eliserichards eliserichards commented Jun 9, 2021

For #19923

Waiting on confirmation from Vesta ✅ (see google doc)

It's probably easier to review these commits separately so you can see the date changes apart from the email changes

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners June 9, 2021 21:23
@eliserichards eliserichards linked an issue Jun 9, 2021 that may be closed by this pull request
3 tasks
Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I believe @pocmo mentioned about getting too much telemetry spam so perhaps we should ping around and figure out an alternative to [email protected] email. Ideally, I think we should just create a new email group for the telemetry owners.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2021

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

@eliserichards
Copy link
Author

[email protected] is the group change approved by @amedyne and @vesta0

@eliserichards eliserichards force-pushed the 19923-renew-telemetry branch from 0191182 to a558b9d Compare June 14, 2021 20:53
@eliserichards eliserichards added the needs:review PRs that need to be reviewed label Jun 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #19924 (8995c54) into master (78edf06) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19924      +/-   ##
============================================
- Coverage     37.00%   37.00%   -0.01%     
  Complexity     1653     1653              
============================================
  Files           542      542              
  Lines         21062    21062              
  Branches       3154     3154              
============================================
- Hits           7795     7794       -1     
  Misses        12366    12366              
- Partials        901      902       +1     
Impacted Files Coverage Δ
...rg/mozilla/fenix/settings/account/AccountUiView.kt 34.14% <0.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78edf06...8995c54. Read the comment docs.

@eliserichards
Copy link
Author

eliserichards commented Jun 14, 2021

Request for Data Collection Renewal

  1. Provide a link to the initial Data Collection Review Request for this collection.
    There are a large number of these, sorry in advance:
    May:

June:

July:
#12114 (review)
#13958 (comment)
#13494 (review)
#15605 (comment)
#11940
#13958 (comment)
#1067 (comment)
#18143
#1677
#18143
#1214 (comment)
#5098 (comment)
#6310
#5090
#5975
#11533
#1214 (comment)
#1344 (comment)
#16076 (comment)
#1708

  1. When will this collection now expire?

All probes that have expired in May, June, or July, with the exception of downloads, about_page, and contextual_hint.tracking_protection`, will now expire in December 2021. These dates are either 12-01-2021 or 12-10-2021 depending on the original add date of the telemetry. See doc for breakdown of individual probes and expiration dates.

  1. Why was the initial period of collection insufficient?

We are continuing to collect this data because it tells us basic usage patterns of the app and gives us information about our new features and what is useful/working. This data is being actively used by the product team for MR2 decisions.

@eliserichards eliserichards added the needs:data-review PR is awaiting a data review label Jun 14, 2021
@travis79
Copy link
Member

Request for Data Collection Renewal

1. Provide a link to the initial Data Collection Review Request for this collection.
   There are a large number of these, sorry in advance:
   May:


* #16727

* #16739

* #16915

June:

* #1896

* #5704

* #5886

* #5975

* #6352

* #6601

* #6746

* [#13958 (comment)](https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877)

* #16968

* #17049

* [#12114 (review)](https://github.com/mozilla-mobile/fenix/pull/12114#pullrequestreview-445245341)

* [#13958 (comment)](https://github.com/mozilla-mobile/fenix/pull/13958#issuecomment-676857877)

* [#13494 (review)](https://github.com/mozilla-mobile/fenix/pull/13494#pullrequestreview-474050499)

* [#15605 (comment)](https://github.com/mozilla-mobile/fenix/pull/15605#issuecomment-702365594)

* #11940

July:
#12114 (review)
#13958 (comment)
#13494 (review)
#15605 (comment)
#11940
#13958 (comment)
#1067 (comment)
#18143
#1677
#18143
#1214 (comment)
#5098 (comment)
#6310
#5090
#5975
#11533
#1214 (comment)
#1344 (comment)
#16076 (comment)
#1708

1. When will this collection now expire?

All probes that have expired in May, June, or July, with the exception of downloads, about_page, and contextual_hint.tracking_protection`, will now expire in December 2021. These dates are either 12-01-2021 or 12-10-2021 depending on the original add date of the telemetry. See doc for breakdown of individual probes and expiration dates.

1. Why was the initial period of collection insufficient?

We are continuing to collect this data because it tells us basic usage patterns of the app and gives us information about our new features and what is useful/working. This data is being actively used by the product team for MR2 decisions.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

@travis79 travis79 removed the needs:data-review PR is awaiting a data review label Jun 15, 2021
app/metrics.yaml Outdated
@@ -432,7 +432,7 @@ events:
- interaction
notification_emails:
- [email protected]
Copy link
Member

@gabrielluong gabrielluong Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one 👻

@eliserichards eliserichards force-pushed the 19923-renew-telemetry branch from a558b9d to 8995c54 Compare June 15, 2021 22:22
@eliserichards eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jun 15, 2021
@eliserichards eliserichards merged commit c32ae71 into mozilla-mobile:master Jun 15, 2021
eliserichards pushed a commit to eliserichards/fenix that referenced this pull request Jun 17, 2021
eliserichards pushed a commit that referenced this pull request Jun 21, 2021
… email address (#20074)

* For #19923: renew telemetry probes (#19924)

* Update glean notification emails to new email group (#20070)
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 20, 2021
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renew expired telemetry probes
4 participants