Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15347 - Adds telemetry for tab settings #15811

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Oct 9, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager
Copy link
Contributor Author

ekager commented Oct 9, 2020

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users enter the new tab settings?
  • What setting (state) do users have at a point in time for tab view and close tab?
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

To measure how useful the different settings for tabs are to users. It will help us prioritize tab related features, and help us understand if the settings are known and understood by users.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • These are new settings, so this is the baseline telemetry.
  1. Can current instrumentation answer these questions?
  • No, see above.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

This data will be present collected until it expires as outlined in the metrics.md file.

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Leanplum / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Leanplum, Amplitude and with mobile teams.

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #15811 into master will decrease coverage by 0.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #15811      +/-   ##
============================================
- Coverage     29.77%   29.76%   -0.02%     
  Complexity     1187     1187              
============================================
  Files           453      453              
  Lines         18500    18517      +17     
  Branches       2391     2395       +4     
============================================
+ Hits           5508     5511       +3     
- Misses        12596    12611      +15     
+ Partials        396      395       -1     
Impacted Files Coverage Δ Complexity Δ
...java/org/mozilla/fenix/components/metrics/Event.kt 31.83% <0.00%> (-0.11%) 0.00 <0.00> (ø)
...org/mozilla/fenix/settings/TabsSettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 68.47% <0.00%> (-1.27%) 35.00 <0.00> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt 12.08% <33.33%> (+0.26%) 4.00 <0.00> (ø)
app/src/main/java/org/mozilla/fenix/Config.kt 54.54% <0.00%> (+4.54%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2cee4...4885f92. Read the comment docs.

@ekager ekager marked this pull request as ready for review October 9, 2020 21:16
@ekager ekager requested review from a team as code owners October 9, 2020 21:16
@ekager ekager added the needs:data-review PR is awaiting a data review label Oct 9, 2020
@gabrielluong gabrielluong requested a review from liuche October 14, 2020 17:35
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Oct 14, 2020
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, this is documented in metrics.md

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, fenix data controls allow users to turn off data collection

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

has expiry

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, setting selection for tab closing, visual, and setting usage

  1. Is the data collection request for default-on or default-off?

On

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Has expiry

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No, uses glean

@liuche liuche removed the needs:data-review PR is awaiting a data review label Oct 14, 2020
@gabrielluong gabrielluong added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Oct 15, 2020
@gabrielluong gabrielluong merged commit 508ec8b into mozilla-mobile:master Oct 15, 2020
@ekager ekager deleted the 15347-tab branch October 15, 2020 02:55
@gabrielluong gabrielluong linked an issue Oct 15, 2020 that may be closed by this pull request
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry] Tabs settings
4 participants