-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #15347 - Adds telemetry for tab settings #15811
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
To measure how useful the different settings for tabs are to users. It will help us prioritize tab related features, and help us understand if the settings are known and understood by users.
This data will be present collected until it expires as outlined in the
|
Codecov Report
@@ Coverage Diff @@
## master #15811 +/- ##
============================================
- Coverage 29.77% 29.76% -0.02%
Complexity 1187 1187
============================================
Files 453 453
Lines 18500 18517 +17
Branches 2391 2395 +4
============================================
+ Hits 5508 5511 +3
- Misses 12596 12611 +15
+ Partials 396 395 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, this is documented in metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, fenix data controls allow users to turn off data collection
- If the request is for permanent data collection, is there someone who will monitor the data over time?
has expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, setting selection for tab closing, visual, and setting usage
- Is the data collection request for default-on or default-off?
On
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiry
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No, uses glean
Pull Request checklist
To download an APK when reviewing a PR: