This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For issue #9949 - Bookmarks/History deletion inconsistencies #12630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12630 +/- ##
============================================
- Coverage 25.82% 25.72% -0.11%
Complexity 890 890
============================================
Files 396 396
Lines 15837 15888 +51
Branches 2038 2042 +4
============================================
- Hits 4090 4087 -3
- Misses 11432 11486 +54
Partials 315 315
Continue to review full report at Codecov.
|
eliserichards
suggested changes
Jul 16, 2020
app/src/main/java/org/mozilla/fenix/library/history/HistoryFragmentStore.kt
Outdated
Show resolved
Hide resolved
BMEduard
force-pushed
the
For/#9949-bookmarks_history_inconsistencies
branch
2 times, most recently
from
a8a6697 to
aa3e538
Compare
…ncies - Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items. - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in mozilla-mobile#8648.
BMEduard
force-pushed
the
For/#9949-bookmarks_history_inconsistencies
branch
from
aa3e538 to
18afafa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in [Library] Deleting is inconsistent between history/bookmarks #8648.
Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.
In order to show the correct headers while items are being hidden/deleted, a map was added in the adapter that keeps the position of the headers and updates it as items are pending for deletion/deleted.
In addition, the state's modes have been reduced to "Normal" and "Editing", since the "Deleting" mode's UI updates (showing and hiding the deletion progress bar) is doesn't overlap the other states.
Pull Request checklist
After merge
To download an APK when reviewing a PR:
Pull Request checklist
After merge
To download an APK when reviewing a PR: