Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #12531: Align Settings -> Private browsing to 72dp keyline #12536

Closed
wants to merge 4 commits into from
Closed

For #12531: Align Settings -> Private browsing to 72dp keyline #12536

wants to merge 4 commits into from

Conversation

hkaancaliskan
Copy link

cc @brampitoyo

Screenshot_1594712979

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

app/src/main/res/xml/private_browsing_preferences.xml Outdated Show resolved Hide resolved
@brampitoyo
Copy link

@hakkikaancaliskan Looks good to me, as well!

@hkaancaliskan
Copy link
Author

@NotWoods could you please label this as needs landing?

@NotWoods NotWoods added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jul 16, 2020
@person808
Copy link
Contributor

Closing for #12654

@person808 person808 closed this Jul 16, 2020
@hkaancaliskan hkaancaliskan deleted the private-pref-redesign branch July 17, 2020 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants