Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11841: Removed topsite bug on private browsing #12020

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

MarcLeclair
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@MarcLeclair MarcLeclair requested a review from ekager June 26, 2020 17:48
@ekager
Copy link
Contributor

ekager commented Jun 26, 2020

Confirmed locally that this fixes the issue

@MarcLeclair MarcLeclair merged commit f3b44c0 into mozilla-mobile:master Jun 26, 2020
@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants