Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix breaking change mozilla-mobile/android-components#7508 #11979

Closed
wants to merge 1 commit into from
Closed

Fix breaking change mozilla-mobile/android-components#7508 #11979

wants to merge 1 commit into from

Conversation

hkaancaliskan
Copy link

This was a breaking change from mozilla-mobile/android-components#7508 on my side. So I just wanted to pr this.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@ekager
Copy link
Contributor

ekager commented Jun 26, 2020

Thanks! This was pulled into #12006

@ekager ekager closed this Jun 26, 2020
@hkaancaliskan hkaancaliskan deleted the 7508-breaking-change branch June 26, 2020 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants