Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #11947: fix and enable closePrivateTabsNotificationTest #11951

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

sv-ohorvath
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath requested a review from AaronMT June 25, 2020 14:00
@sv-ohorvath sv-ohorvath self-assigned this Jun 25, 2020
@sv-ohorvath sv-ohorvath added the eng:ui-test UI Tests label Jun 25, 2020
@sv-ohorvath sv-ohorvath linked an issue Jun 25, 2020 that may be closed by this pull request
@AaronMT AaronMT merged commit 932a032 into master Jun 25, 2020
@sv-ohorvath sv-ohorvath deleted the privateNotificationTest branch June 26, 2020 07:15
@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and enable closePrivateTabsNotificationTest
2 participants