Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fixes #11764: delay single-click duration to avoid long-clicks in ThreeDotMenu UI tests #11949

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

sv-ohorvath
Copy link
Contributor

@sv-ohorvath sv-ohorvath commented Jun 25, 2020

For #11764. The test remains disabled until the GV bug causing instrumentation crashes is fixed.
Also fixed some flaky Settings items verifications.
Verified the tests 20x times using the flank-x86 config file before opening the PR.

@sv-ohorvath sv-ohorvath self-assigned this Jun 25, 2020
@sv-ohorvath sv-ohorvath requested review from AaronMT and rpappalax June 25, 2020 13:44
@sv-ohorvath sv-ohorvath added eng:ui-test UI Tests eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer labels Jun 25, 2020
@AaronMT
Copy link
Contributor

AaronMT commented Jun 25, 2020

I don't know much about this setting at all. Does it work different API versions?

@AaronMT AaronMT merged commit 45bc42f into master Jun 25, 2020
@sv-ohorvath sv-ohorvath removed the request for review from rpappalax June 26, 2020 07:16
@sv-ohorvath sv-ohorvath deleted the 3dotMenuItemsTest branch June 26, 2020 07:16
@sv-ohorvath
Copy link
Contributor Author

I don't know much about this setting at all. Does it work different API versions?

I tried it on API 25 and didn't see any issues. I think it should be ok. The solution was from a book Android Espresso Revealed: Writing Automated Unit Tests by Denys Zelenchuk...

@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest
2 participants