Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11901: Use safe call for collection item info. #11904

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Jun 24, 2020

Pull Request checklist

Fixes #11901

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

false,
initialInfo.isSelected
)
info.collectionItemInfo = initialInfo?.let {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
info.collectionItemInfo = initialInfo?.let {
info.collectionItemInfo = info.collectionItemInfo?.let { initialInfo ->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes it more clear. Thanks!

@ekager ekager merged commit b961fdc into mozilla-mobile:master Jun 25, 2020
@mcarare mcarare deleted the 11901 branch October 21, 2020 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
3 participants