Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fixes #11797: defaultDesktopBookmarksFoldersTest intermittent failure #11803

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

sv-ohorvath
Copy link
Contributor

@sv-ohorvath sv-ohorvath commented Jun 22, 2020

Assertion failure on the Sign in to sync button.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath self-assigned this Jun 22, 2020
@sv-ohorvath sv-ohorvath added eng:ui-test UI Tests eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer labels Jun 22, 2020
@sv-ohorvath sv-ohorvath linked an issue Jun 22, 2020 that may be closed by this pull request
@sv-ohorvath sv-ohorvath reopened this Jun 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #11803 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11803   +/-   ##
=========================================
  Coverage     21.93%   21.93%           
  Complexity      716      716           
=========================================
  Files           376      376           
  Lines         15047    15047           
  Branches       1951     1951           
=========================================
  Hits           3301     3301           
+ Misses        11464    11463    -1     
- Partials        282      283    +1     
Impacted Files Coverage Δ Complexity Δ
.../fenix/browser/browsingmode/BrowsingModeManager.kt 85.71% <0.00%> (-14.29%) 0.00% <0.00%> (ø%)
app/src/main/java/org/mozilla/fenix/Config.kt 36.11% <0.00%> (+2.77%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb45b37...f6be3ab. Read the comment docs.

@AaronMT AaronMT removed the request for review from isabelrios June 22, 2020 15:03
@AaronMT AaronMT merged commit 79f231b into master Jun 22, 2020
@sv-ohorvath sv-ohorvath deleted the defaultBkmFolders branch June 22, 2020 15:18
@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent UI test failure - defaultDesktopBookmarksFoldersTest
3 participants