Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10642: Comment out verifyPageContent calls #11748

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Jun 18, 2020

Issue #10642 (verifyPageContent) is very flaky and causing test timeouts in test-failures. I wouldn't be surprised if the MockWebServer version we're using from 2018 is part of the problem, for now comment out each verifyPageContent call and the function. Retaining its definition so we can still investigate on the side.

@AaronMT AaronMT added the eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer label Jun 18, 2020
@AaronMT AaronMT self-assigned this Jun 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #11748 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11748      +/-   ##
============================================
- Coverage     21.81%   21.76%   -0.06%     
  Complexity      716      716              
============================================
  Files           375      375              
  Lines         15048    15071      +23     
  Branches       1952     1957       +5     
============================================
- Hits           3283     3280       -3     
- Misses        11482    11508      +26     
  Partials        283      283              
Impacted Files Coverage Δ Complexity Δ
.../fenix/browser/browsingmode/BrowsingModeManager.kt 85.71% <0.00%> (-14.29%) 0.00% <0.00%> (ø%)
...nix/components/toolbar/BrowserToolbarController.kt 68.20% <0.00%> (-2.32%) 0.00% <0.00%> (ø%)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 8.67% <0.00%> (+<0.01%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82cbafa...c2e3da3. Read the comment docs.

fix: expectedText not called warning
@AaronMT AaronMT force-pushed the remove-verifyPageContent branch from 9f9c3f4 to c2e3da3 Compare June 18, 2020 19:45
@AaronMT AaronMT added the eng:automation Build automation, Continuous integration, .. label Jun 18, 2020
@AaronMT AaronMT requested a review from rpappalax June 18, 2020 20:07
@AaronMT AaronMT added the eng:ui-test UI Tests label Jun 18, 2020
@rpappalax rpappalax merged commit 4270c83 into master Jun 18, 2020
@rpappalax rpappalax deleted the remove-verifyPageContent branch June 18, 2020 22:25
@rpappalax
Copy link
Contributor

Issue #10642 (verifyPageContent) is very flaky and causing test timeouts in test-failures. I wouldn't be surprised if the MockWebServer version we're using from 2018 is part of the problem, for now comment out each verifyPageContent call and the function. Retaining its definition so we can still investigate on the side.

@AaronMT thanks, Aaron. Is the follow-up work being tracked in a separate issue? I want to make sure this has a clear owner before we move on

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, .. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants