This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #9229, for #11665: Update Delete browsing data screens #11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11693 +/- ##
============================================
+ Coverage 21.52% 21.61% +0.08%
Complexity 700 700
============================================
Files 374 374
Lines 15067 15098 +31
Branches 2035 2036 +1
============================================
+ Hits 3243 3263 +20
- Misses 11543 11554 +11
Partials 281 281
Continue to review full report at Codecov.
|
| @@ -26,6 +26,14 @@ | |||
| <string name="pref_key_delete_cookies_on_quit" translatable="false">pref_key_delete_cookies_on_quit</string> | |||
| <string name="pref_key_delete_caches_on_quit" translatable="false">pref_key_delete_caches_on_quit</string> | |||
| <string name="pref_key_delete_permissions_on_quit" translatable="false">pref_key_delete_permissions_on_quit</string> | |||
| <string name="pref_key_delete_browsing_data_now_categories" translatable="false">pref_key_delete_browsing_data_now_categories</string> | |||
There was a problem hiding this comment.
First and last two added strings seem to not be used, please remove them if so
| android:title="@string/preferences_delete_browsing_data_tabs_title_2" /> | ||
| <CheckBoxPreference | ||
| android:key="@string/pref_key_delete_browsing_history_on_quit" | ||
| android:layout="@layout/delete_browsing_category_checkbox" | ||
| android:title="@string/preferences_delete_browsing_data_on_quit_browsing_history" /> |
There was a problem hiding this comment.
Please remove from strings.xml the deleted string since here was its last usage
BranescuMihai
approved these changes
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: