Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11542: Update tabs positions in tab tray reported by screen readers #11636

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Jun 16, 2020

Fixes #11542

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare mcarare requested a review from darkwing June 16, 2020 11:30
@codecov-commenter
Copy link

Codecov Report

Merging #11636 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11636      +/-   ##
============================================
- Coverage     21.55%   21.51%   -0.04%     
  Complexity      700      700              
============================================
  Files           373      373              
  Lines         15066    15090      +24     
  Branches       2036     2038       +2     
============================================
  Hits           3247     3247              
- Misses        11537    11561      +24     
  Partials        282      282              
Impacted Files Coverage Δ Complexity Δ
...java/org/mozilla/fenix/tabtray/FenixTabsAdapter.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/org/mozilla/fenix/tabtray/TabTrayView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/tabtray/TabTrayViewHolder.kt 32.43% <0.00%> (-5.67%) 7.00 <0.00> (ø)
app/src/main/java/org/mozilla/fenix/Config.kt 33.33% <0.00%> (ø) 2.00% <0.00%> (ø%)
.../java/org/mozilla/fenix/utils/RunWhenReadyQueue.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3535bec...7f7fc4b. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab Tray A11y - First tab in list is read as "3 of 3"
3 participants