Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

for #9407: fixed and added collection tests #10566

Merged
merged 1 commit into from
May 12, 2020
Merged

Conversation

sv-ohorvath
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath self-assigned this May 11, 2020
@sv-ohorvath sv-ohorvath requested review from AaronMT and rpappalax May 11, 2020 15:23
@sv-ohorvath sv-ohorvath added the eng:automation Build automation, Continuous integration, .. label May 11, 2020
@sv-ohorvath sv-ohorvath reopened this May 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #10566 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10566   +/-   ##
=========================================
  Coverage     19.34%   19.34%           
  Complexity      602      602           
=========================================
  Files           360      360           
  Lines         14621    14621           
  Branches       1959     1959           
=========================================
  Hits           2829     2829           
  Misses        11535    11535           
  Partials        257      257           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a8bf7...98a76d7. Read the comment docs.

Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @sv-ohorvath - see two comments prior to merge

@sv-ohorvath sv-ohorvath removed the request for review from rpappalax May 12, 2020 07:51
@sv-ohorvath sv-ohorvath merged commit 56e0dd8 into master May 12, 2020
@sv-ohorvath sv-ohorvath deleted the collectionsTests branch May 12, 2020 07:51
@liuche liuche mentioned this pull request May 19, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants