This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For 10503 - Update save to collection flow in tab tray #10523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
commented
May 8, 2020
| if (navController.currentDestination?.id == R.id.collectionCreationFragment) return | ||
|
|
||
| // Only register the observer right before moving to collection creation | ||
| // registerCollectionStorageObserver() |
There was a problem hiding this comment.
@boek I left this in the patch but commented out, as it's in the HomeFragment's implementation, but I don't understand what it's doing for us. Do we need this?
Also, upon saving to collection the tabs don't go away. Is that something we need to be doing?
There was a problem hiding this comment.
We don't have collections on the tab tray so we don't need to register for that observer here!
There was a problem hiding this comment.
And no, I think that behavior was confusing so we stopped removing the tabs that we were saving to the collection
darkwing
added
the
pr:work-in-progress
darkwing
force-pushed
the
tab-tray-save-collection
branch
from
2167f10 to
bc26bd3
Compare
boek
approved these changes
May 11, 2020
| if (navController.currentDestination?.id == R.id.collectionCreationFragment) return | ||
|
|
||
| // Only register the observer right before moving to collection creation | ||
| // registerCollectionStorageObserver() |
There was a problem hiding this comment.
And no, I think that behavior was confusing so we stopped removing the tabs that we were saving to the collection
darkwing
force-pushed
the
tab-tray-save-collection
branch
from
bc26bd3 to
a4559bf
Compare
darkwing
force-pushed
the
tab-tray-save-collection
branch
from
a4559bf to
7142bb5
Compare
darkwing
removed
the
pr:work-in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10503
Pull Request checklist
After merge
To download an APK when reviewing a PR: