Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10196: Remove clickable locks for enable and private-browsing UI #10445

Merged
merged 1 commit into from
May 6, 2020

Conversation

psymoon
Copy link
Contributor

@psymoon psymoon commented May 6, 2020

We don't need clickable locks for other UI switches and in low memory, the locks would prevent other switch clicks from happening (i.e. during enable -> disable, trying to switch private browsing mode would be locked hence looks broken).

@codecov-io
Copy link

Codecov Report

Merging #10445 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10445      +/-   ##
============================================
+ Coverage     19.53%   19.54%   +0.01%     
  Complexity      601      601              
============================================
  Files           357      357              
  Lines         14422    14414       -8     
  Branches       1940     1940              
============================================
  Hits           2817     2817              
+ Misses        11349    11341       -8     
  Partials        256      256              
Impacted Files Coverage Δ Complexity Δ
...illa/fenix/addons/InstalledAddonDetailsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a3613...2f871a5. Read the comment docs.

@psymoon psymoon merged commit 609936d into mozilla-mobile:master May 6, 2020
@psymoon psymoon deleted the private-browsing branch May 6, 2020 17:58
@liuche liuche mentioned this pull request May 19, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants