Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10395 - Improve alignment of close buttons with menu in tab tray #10405

Merged
merged 1 commit into from
May 5, 2020

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented May 4, 2020

Fixes #10395

Screenshot_20200504-123944

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

Codecov Report

Merging #10405 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10405      +/-   ##
============================================
- Coverage     19.56%   19.53%   -0.04%     
  Complexity      601      601              
============================================
  Files           357      357              
  Lines         14396    14421      +25     
  Branches       1937     1940       +3     
============================================
  Hits           2817     2817              
- Misses        11323    11348      +25     
  Partials        256      256              
Impacted Files Coverage Δ Complexity Δ
.../mozilla/fenix/customtabs/CustomTabsIntegration.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c9aaa...2eb858a. Read the comment docs.

@darkwing darkwing requested a review from topotropic May 4, 2020 20:41
@gabrielluong gabrielluong linked an issue May 5, 2020 that may be closed by this pull request
3 tasks
Copy link

@topotropic topotropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sblatz sblatz merged commit 5087bcf into mozilla-mobile:master May 5, 2020
@liuche liuche mentioned this pull request May 19, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Small visual updates for dedicated tab tray
4 participants