Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #9946: Update FennecBeta branding #10066

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Apr 20, 2020

This is now ready to land!

image

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz added pr:do-not-land pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Apr 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #10066 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10066   +/-   ##
=========================================
  Coverage     19.26%   19.26%           
  Complexity      532      532           
=========================================
  Files           340      340           
  Lines         13790    13790           
  Branches       1847     1847           
=========================================
  Hits           2657     2657           
  Misses        10895    10895           
  Partials        238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d51c4f...8755d5a. Read the comment docs.

@sblatz sblatz force-pushed the update-beta-branding branch from 8755d5a to d519ed8 Compare April 22, 2020 21:20
@sblatz sblatz removed pr:do-not-land pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Apr 22, 2020
Copy link
Contributor

@kglazko kglazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct icons are in this PR

@sblatz sblatz merged commit 95f26f1 into mozilla-mobile:master Apr 22, 2020
Amejia481 pushed a commit to Amejia481/fenix that referenced this pull request Apr 23, 2020
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
liuche added a commit to liuche/fenix that referenced this pull request Apr 28, 2020
liuche added a commit that referenced this pull request Apr 28, 2020
@vesta0 vesta0 mentioned this pull request May 12, 2020
2 tasks
liuche added a commit to liuche/fenix that referenced this pull request Jun 24, 2020
liuche added a commit to liuche/fenix that referenced this pull request Jun 25, 2020
liuche added a commit to liuche/fenix that referenced this pull request Jun 25, 2020
liuche added a commit that referenced this pull request Jun 25, 2020
…refox Beta (#11872)

* Revert "For #9946: Update FennecBeta branding (#10066)" to push to Firefox Beta.

This reverts commit 95f26f1.

* No issue: Test remove codecov (#11928)

Co-authored-by: Emily Kager <[email protected]>
pocmo pushed a commit that referenced this pull request Jun 30, 2020
…refox Beta (#11872)

* Revert "For #9946: Update FennecBeta branding (#10066)" to push to Firefox Beta.

This reverts commit 95f26f1.

* No issue: Test remove codecov (#11928)

Co-authored-by: Emily Kager <[email protected]>
liuche added a commit to liuche/fenix that referenced this pull request Jun 30, 2020
…mobile#10066)" to push to Firefox Beta (mozilla-mobile#11872)

* Revert "For mozilla-mobile#9946: Update FennecBeta branding (mozilla-mobile#10066)" to push to Firefox Beta.

This reverts commit 95f26f1.
boek pushed a commit that referenced this pull request Jul 1, 2020
…refox Beta (#11872)

* Revert "For #9946: Update FennecBeta branding (#10066)" to push to Firefox Beta.

This reverts commit 95f26f1.
@liuche liuche mentioned this pull request Jul 20, 2020
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants