Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] radio groups on first run are a mess in Talkback #9722

Closed
asadotzler opened this issue Apr 5, 2020 · 7 comments
Closed

[Bug] radio groups on first run are a mess in Talkback #9722

asadotzler opened this issue Apr 5, 2020 · 7 comments
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR P2 Upcoming release

Comments

@asadotzler
Copy link

asadotzler commented Apr 5, 2020

Steps to reproduce

Install a fresh Fenix or delete your Fenix storage
Enable Talkback
Swipe through first run cards with radio groups

Expected behavior

Swiping to the first option reads the whole thing and swiping again moves to the next option.

Actual behavior

Swiping navigates the group then the internals of the group from the control to the label to description all before moving to the next radio option.

Device information

  • Android device: Galaxy S10e
  • Fenix version: Friday 4/3 @ 6:10 AM

For example, here's what I expect to hear when I get to the Protect Yourself radio choice:

Swipe right: "Not checked radio button. Standard. Blocks fewer trackers but allows pages to load normally. Double tap to activate."
Swipe right: "Checked radio button. Strict recommended. Blocks more trackers for better protection and performance, but may cause some sites to not work properly. Double tap to activate."

But what I actually get is this:

Swipe right: "Standard. Blocks fewer trackers but allows pages to load normally. Double tap to activate."
Swipe right: "Not checked radio button. Double tap to toggle."
Swipe right: "Standard"
Swipe right: "Blocks fewer trackers but allows pages to load normally."
Swipe right: "Strict recommended. Blocks more trackers for better protection and performance, but may cause some sites to not work properly. Double tap to activate."
Swipe right: "Checked radio button. Double tap to toggle."
Swipe right: "Strict recommended."
Swipe right: "Blocks more trackers for better protection and performance, but may cause some sites to not work properly."

See the difference? The first one is clean and quick and the second one is a mess.

And it's the same basic problem for the "Theme" and "Take a position" cards but it might even be a little worse there actually. For the cards with image radio choices, the labels under the images aren't grouped with the image they belong to.

┆Issue is synchronized with this Jira Task

@asadotzler asadotzler added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. labels Apr 5, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 5, 2020
@asadotzler
Copy link
Author

This is an accessibility P2. The feature is available and works but is difficult to use because of inconsiderate focus/swipe behavior. This kind of bug prevents Fenix from being a delightful experience for users with disabilities.

@kbrosnan kbrosnan added the Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR label Apr 8, 2020
@asadotzler asadotzler added the P2 Upcoming release label May 7, 2020
@asadotzler asadotzler removed the needs:triage Issue needs triage label May 18, 2020
@BranescuMihai BranescuMihai self-assigned this Jun 19, 2020
@BranescuMihai BranescuMihai removed their assignment Jun 24, 2020
@BranescuMihai
Copy link
Contributor

Seems like it's more difficult than initially expected, don't think I can finish it before code freeze so I'm unassigning myself. @mcarare have any thoughts on this? I know you have experience with accessibility issues

@mcarare
Copy link
Contributor

mcarare commented Jun 25, 2020

I do not believe there is a quick fix for this. In the future IMO we should explore using a custom view radio button that includes the title, description and or image.

@mcarare mcarare self-assigned this Jul 13, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jul 15, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jul 16, 2020
Add title and description to button text, remove extra Textviews.
mcarare added a commit to mcarare/fenix that referenced this issue Jul 16, 2020
Add title and description to button text, remove extra Textviews.
@BranescuMihai BranescuMihai added the E5 Estimation Point: about 5 days label Jul 20, 2020
boek pushed a commit that referenced this issue Jul 21, 2020
Add title and description to button text, remove extra Textviews.
@boek boek added the eng:qa:needed QA Needed label Jul 21, 2020
@sflorean
Copy link
Contributor

Testing results on Nightly 7/24 for the Protect Yourself radio choice:

Swipe right: "Checked Standard default. Standard. Pages will load normally. Double-tap to toggle."
Swipe right: "Not Checked Strict. Blocks more trackers, ads, and popups. Pages load faster, but some functionality might not work. Double-tap to toggle."

After swiping right a couple of times and reach to "Dark theme" selected, swiping again I got the following "No next link".

@mcarare could you please, tell your opinion about the "No next link" item?

@sflorean sflorean removed the eng:qa:needed QA Needed label Jul 24, 2020
@mcarare
Copy link
Contributor

mcarare commented Jul 24, 2020

@sflorean That is the standard "end of page" announcement for Talkback, I suspect the screen was scrolled to a point where no other element is visible and added to the a11y tree. It should not reproduce at the same point if the screen is scrolled more. And either way, it's not directly related to radio buttons.

@sflorean
Copy link
Contributor

@sflorean That is the standard "end of page" announcement for Talkback, I suspect the screen was scrolled to a point where no other element is visible and added to the a11y tree. It should not reproduce at the same point if the screen is scrolled more. And either way, it's not directly related to radio buttons.

After clear data, I'm not able to reproduce anymore. Closing as verified.

@sflorean sflorean added the eng:qa:verified QA Verified label Jul 24, 2020
@abodea
Copy link
Member

abodea commented Aug 25, 2020

Verified as fixed on Fenix RC 80.1.0 with Google Pixel 4 XL (11).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR P2 Upcoming release
Projects
None yet
Development

No branches or pull requests

7 participants