Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Menu and Setting icons are not proportionate with other icons #9205

Closed
Scripterr opened this issue Mar 17, 2020 · 9 comments
Closed

[Bug]Menu and Setting icons are not proportionate with other icons #9205

Scripterr opened this issue Mar 17, 2020 · 9 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. implementation review

Comments

@Scripterr
Copy link

Scripterr commented Mar 17, 2020

Steps to reproduce

Reproduce in menu-

  1. open webpage.
  2. click 3 dot menu and observe.

Reproduce in settings-

  1. open settings and observe.

Expected behavior

All menu icons in 3 dot menu and settings are proportionate with other icons.

Actual behavior

Add-on manager and open in app menu item are bigger than other icons in menu and settings.

Screenshot_20200315-184208_1_1
Screenshot_20200604-125206_1

Device information

  • Android device: 8.0.0
  • Fenix version: nightly

┆Issue is synchronized with this Jira Task

@Scripterr Scripterr added the 🐞 bug Crashes, Something isn't working, .. label Mar 17, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 17, 2020
@ValentinTimisica ValentinTimisica added Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. needs:UX-feedback Needs UX Feedback labels Jun 4, 2020
@ekager
Copy link
Contributor

ekager commented Jun 4, 2020

@brampitoyo could you help us get mobile-specific icons for these assets? I think they were likely pulled from design.firefox which makes them a bit out of proportion to other mobile icons

@ekager ekager added implementation review and removed needs:triage Issue needs triage labels Jun 4, 2020
@brampitoyo brampitoyo self-assigned this Jun 7, 2020
@brampitoyo
Copy link

I can confirm that our mobile-specific icon does look smaller and more in proportion. Sorry about that.

Posting the asset below:
https://dzwonsemrish7.cloudfront.net/items/1K1P0p0T0h1g1W2G1j1v/extensions.svg

@brampitoyo brampitoyo added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels Jun 7, 2020
@brampitoyo brampitoyo removed their assignment Jun 7, 2020
@Scripterr
Copy link
Author

Scripterr commented Jun 8, 2020

Hello @brampitoyo , I also think that open in app also have unproportionate size could you please check , cause I'm only seeing new icon for add-ons from the link you have provided above.

@brampitoyo
Copy link

@Scripterr I just rechecked our design repository, and found that the “Open in app” icon does look larger than the rest. It occupies the 24x24dp grid fully, whereas other icons seem to have 2dp untouchable inner margins.

@ValentinTimisica
Copy link
Contributor

So @brampitoyo based on your above comment, considering that the "Open in app" icon is bigger than the others, can you give us the correct icon?

@brampitoyo
Copy link

Here’s a version of app.svg with slightly reduced outer frame. This make it look optically correct when seen alongside other icons, although the untouchable inner margins had to be odd-numbered (3dp instead of 2dp) as a result.

https://share.getcloudapp.com/QwulYPPm

@brampitoyo brampitoyo removed their assignment Jun 10, 2020
@ekager
Copy link
Contributor

ekager commented Jun 10, 2020

Thanks Bram! This is ready for eng to pick up and update the assets 👍

@ValentinTimisica
Copy link
Contributor

Reopening for QA.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 23, 2020

Hi, verified as fixed on the latest Nightly Build 200623 from 6/23 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► ⋮ Main menu
Now ➡️ Before
rrrrsz_screenshot_20200623-135100

► Settings section
Now
⬇️
Before
rssssz_screenshot_20200623-135002

@AndiAJ AndiAJ closed this as completed Jun 23, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 23, 2020
@liuche liuche mentioned this issue Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. implementation review
Projects
None yet
Development

No branches or pull requests

5 participants