Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix intermittent fail on ReaderViewTest.verifyReaderViewAppearanceFontToggle UI test #9188

Closed
rpappalax opened this issue Mar 16, 2020 · 5 comments · Fixed by #17661
Closed
Assignees
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests

Comments

@rpappalax
Copy link
Contributor

rpappalax commented Mar 16, 2020

This test passes on API 28 but not on API 25

 androidx.test.espresso.base.DefaultFailureHandler$AssertionFailedWithCauseError
androidx.test.espresso.base.DefaultFailureHandler$AssertionFailedWithCauseError: 'view has effective visibility=VISIBLE' doesn't match the selected view.
Expected: view has effective visibility=VISIBLE
Got: "AppCompatImageView{id=2131297023, res-name=notification_dot, desc=Highlighted, visibility=GONE, width=0, height=0, has-focus=false, has-focusable=false, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=true, is-selected=false, layout-params=android.widget.FrameLayout$LayoutParams@a1d4c6d, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0}" 

https://console.firebase.google.com/u/0/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/7649116021264846893/executions/bs.86d4d41684492d44/testcases/1/test-cases

┆Issue is synchronized with this Jira Task

@rpappalax rpappalax added 🐞 bug Crashes, Something isn't working, .. eng:automation Build automation, Continuous integration, .. labels Mar 16, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 16, 2020
@rpappalax rpappalax removed the needs:triage Issue needs triage label Mar 17, 2020
@AaronMT
Copy link
Contributor

AaronMT commented Mar 17, 2020

I think assertReaderViewDetected needs to wait until the appearance of the blue dot on the 3 dot menu (if it's still part of the feature).

@AaronMT
Copy link
Contributor

AaronMT commented Jul 7, 2020

Reader Mode entry/exit is changed in product so the test would need to be updated. This might not be an issue anymore. Reader mode tests currently blocked by #11191

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jan 26, 2021

#11191 was fixed but this test is flaky now on API 28: https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/8528873179388097367/executions/bs.c4b507f8aa6ea73/testcases/2/test-cases
androidx.test.espresso.NoMatchingViewException: No views in hierarchy found matching: (with string from resource id: <2131951736>[browser_menu_read_appearance] value: Appearance)

@sv-ohorvath sv-ohorvath changed the title Fix intermittent fail on verifyReaderViewAppearanceFontToggle UI test Fix intermittent fail on ReaderViewTest.verifyReaderViewAppearanceFontToggle UI test Jan 26, 2021
@sv-ohorvath
Copy link
Contributor

verifyReaderViewAppearanceColorSchemeChange failed 1 out of 2 tries with the same error, on Master 1/27: https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/5053320726265191428/executions/bs.c2ae71640776911a/testcases/1/test-cases

@sv-ohorvath sv-ohorvath added eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests and removed eng:automation Build automation, Continuous integration, .. 🐞 bug Crashes, Something isn't working, .. labels Jan 28, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants