Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] White screen when using back swipe to close Firefox Preview and reopening from 'Recents' #9144

Closed
adityamurugan opened this issue Mar 13, 2020 · 4 comments · Fixed by #11772
Closed

[Bug] White screen when using back swipe to close Firefox Preview and reopening from 'Recents' #9144

adityamurugan opened this issue Mar 13, 2020 · 4 comments · Fixed by #11772
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill

Comments

@adityamurugan
Copy link

adityamurugan commented Mar 13, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Close Firefox preview
  2. Open external link in Firefox Preview
  3. Use back button/back swipe to close Firefox Preview
  4. Open Firefox Preview again from 'Recents'

Expected behavior

Firefox Preview should open the home page without any white screens

Actual behavior

Firefox preview shows a blank white screen and need to be closed and opened to fix

Device information

  • Android device: Pixel 3a
  • Fenix version: Nightly 200312 18.01

┆Issue is synchronized with this Jira Task
@adityamurugan adityamurugan added the 🐞 bug Crashes, Something isn't working, .. label Mar 13, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 13, 2020
@adityamurugan adityamurugan changed the title [Bug] [Bug] White screen when using back swipe to close Firefox Preview and reopening from 'Recents' Mar 13, 2020
@sblatz
Copy link
Contributor

sblatz commented Mar 13, 2020

Video of the behavior: https://www.reddit.com/r/firefox/comments/fhsemk/bugfenix_white_screen_when_using_back_swipe_to/

@boek boek added P1 Current sprint S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill and removed needs:group-triage needs:triage Issue needs triage labels Mar 17, 2020
@adityamurugan
Copy link
Author

There has been a small change in behavior but the bug is still there.

-The first back swipe closes the external link tab and the home page is shown
-The second back swipe minimizes the app to recents
-Now, trying to reopen the app from the recents drawer shows a white screen.

Version: Nightly 200416 08:30 (Build #21070840)

@sflorean
Copy link
Contributor

Tested on Nightly 6/12 and I was able to reproduce the issue on the following devices, only if the page from step 2 is opened in the browser:

  • Google Pixel 3 (Android 11-beta)
  • LG G7 FIT (Android 8)
    If I have more than 1 open tabs, the previous open tab is displayed after I open Nightly from Recents.

@Mugurell Mugurell self-assigned this Jun 18, 2020
ekager pushed a commit that referenced this issue Jun 22, 2020
@Mugurell @ekager
For #9144 - Ignore previous Intent if activity is started from Recents
0ba1d26 
We'll now clearly differentiate between cold / hot starts of HomeActivity.kt.
This is needed because Android will resend the original Intent which initially
started the Activity whenever it is restarted from the Recents Screen if the
activity is already destroyed at that time. So in the event that the activity
was before started with an Intent to open a webpage for example whenever the
activity is restarted from Recents it will receive the same Intent to open a
webpage even though that Intent has already been consumed.

Activity's onCreate() will only use the intent processors when the activity is
cold started so that we'll only initially act upon Intents configured for
different behaviors inside the app.
If the activity is destroyed while in background and opened from Recents it
will not act upon the original Intent which is now resent by Android.

Activity's onNewIntent() will be called to act upon a new Intent if the
activity is hot started since we are declared as singleTask and it now has the
responsibility to delegate various intent processors to consume that Intent.
@ekager ekager added the eng:qa:needed QA Needed label Jun 22, 2020
@abodea
Copy link
Member

abodea commented Jun 23, 2020

Verified as fixed on the latest Nightly 6/23 with Google Pixel 4 XL (10).
Note that the home page was displayed in both cases when I had 1 or more tabs open.

20200623-115708

@abodea abodea closed this as completed Jun 23, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 23, 2020
This was referenced Jun 23, 2020
Closed
Merged
Closed
Closed
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@Mugurell Mugurell mentioned this issue Jul 7, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #9144 - Ignore previous Intent if activity is started from Recents
7 participants
@boek @sblatz @Mugurell @ekager @abodea @adityamurugan @sflorean