Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Padding in some checkboxes is improper in settings #7928

Closed
s-ankur opened this issue Jan 25, 2020 · 9 comments
Closed

[Bug] Padding in some checkboxes is improper in settings #7928

s-ankur opened this issue Jan 25, 2020 · 9 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@s-ankur
Copy link
Contributor

s-ankur commented Jan 25, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

Open settings
Go to set as default browser
tap/ hold the open links in .. checkbox

Expected behavior

The padding is proper like this option:
Screenshot_20200125-133820

Actual behavior

Very low padding
Screenshot_20200125-133449

Device information

  • Android device: Asus zenfone m1
  • Fenix version: Nightly 200124 06:01 (Build #20240607)
    29.0.0, ae1ba0f02
    GV: 74.0a1-20200122094859

┆Issue is synchronized with this Jira Task
@s-ankur s-ankur added the 🐞 bug Crashes, Something isn't working, .. label Jan 25, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 25, 2020
@s-ankur
Copy link
Contributor Author

s-ankur commented Jan 25, 2020

Similar problem in clear browsing data option
Screenshot_20200125-134015

@s-ankur
Copy link
Contributor Author

s-ankur commented Jan 25, 2020

And here:
Screenshot_20200125-135109

@kbrosnan kbrosnan added Feature:Settings help wanted Help wanted from a contributor. More complex than good first issue. labels Feb 15, 2020
@kbrosnan
Copy link
Contributor

This is still an issue after the Settings re-org #8240

miDeb added a commit to miDeb/fenix that referenced this issue Mar 6, 2020
@miDeb
Fix mozilla-mobile#7928: Add padding to checkbox
51daad1
@miDeb
Copy link
Contributor

miDeb commented Mar 6, 2020

I could only reproduce the last one (Show in private sessions).

@miDeb miDeb mentioned this issue Mar 6, 2020
Closed
4 tasks
@mcarare mcarare added the eng:qa:needed QA Needed label Mar 27, 2020
@mcarare
Copy link
Contributor

mcarare commented Mar 27, 2020

For QA: This seems to be fixed.
Note for #7928 (comment): this was fixed and checked in #8600.

@sv-sdeiac
Copy link

Hi, I can confirm that the issue is fixed using the latest version of Firefox Preview Nightly 3/29 #20891805.

Devices:

  • Google Pixel (Android 10);
  • LG g7 fit (Android 8.1).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 30, 2020
@s-ankur
Copy link
Contributor Author

s-ankur commented Apr 16, 2020

Hi, I can still see this issue in latest nightly
Screenshot_20200416-163928_Firefox_Nightly

@ekager ekager removed the needs:triage Issue needs triage label Apr 17, 2020
@s-ankur
Copy link
Contributor Author

s-ankur commented Apr 18, 2020

@sv-sdeiac I think this needs to be reopened

@miDeb
Copy link
Contributor

miDeb commented Apr 18, 2020

This is intentional: #8600 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7928: Add padding to checkbox miDeb/fenix
6 participants
@kbrosnan @ekager @s-ankur @sv-sdeiac @miDeb @mcarare