Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y]Common myth hyperlink button to small - consider making larger #7887

Closed
sv-sdeiac opened this issue Jan 23, 2020 · 3 comments
Closed
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified needs:triage Issue needs triage P2 Upcoming release

Comments

@sv-sdeiac
Copy link

sv-sdeiac commented Jan 23, 2020

Prerequisites

  1. Make sure you have Google Accessibility Scanner installed.

Steps to reproduce

  1. Tap on the private mode button;
  2. Without any page opened, scan the "private mode" section using the Accessibility Scanner.

Expected behavior

There are no suggestions to make any changes.

Actual behavior

There is a suggestion to consider making the Common myth hyperlink button larger - as seen in the screenshot below.

Device information

  • Android device: Samsung Galaxy Tab S3 (Android 8.0)
  • Fenix version: 3.2.0-beta.2 #20230233
    Screenshot_20200123-160701_Accessibility Scanner

┆Issue is synchronized with this Jira Task

@sv-sdeiac sv-sdeiac added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. S3 Blocks non-critical functionality and a work around exists labels Jan 23, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 23, 2020
@sv-sdeiac sv-sdeiac changed the title [Bug]Common myth hyperlink button to small - consider making larger [Bug][a11y]Common myth hyperlink button to small - consider making larger Jan 23, 2020
@sblatz sblatz added E1 Estimation Point: trivial, less than half day P3 Some future sprint and removed S3 Blocks non-critical functionality and a work around exists labels Jan 29, 2020
@Diana-Rus
Copy link

Diana-Rus commented Apr 1, 2020

Hi, this ticket has a duplicate #7708. Because here the priority was set i am going to close the other one.
Put as note the comment from the other:
sblatz commented on Jan 29 :

Make this say "button" (it should be a button or link object)
It should have 48dp.

@mcarare
Copy link
Contributor

mcarare commented Apr 29, 2020

I am filling a separate issue for the type announcement as it is a problem that should be addressed for multiple similar links: #10285

@mcarare mcarare self-assigned this Apr 29, 2020
@asadotzler asadotzler added the P2 Upcoming release label May 7, 2020
@ekager ekager added the eng:qa:needed QA Needed label May 12, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented May 12, 2020

Hi, verified as fixed on the latest Nightly Build 200512 from 5/12 using the following devices:
• Google Pixel 3a (Android 10)
• OnePlus A3 (Android 6.0.1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified needs:triage Issue needs triage P2 Upcoming release
Projects
None yet
Development

No branches or pull requests

8 participants