[Bug] Bookmark's edited name is not saved after selecting in which folder to save

[lobontiumira]

Steps to reproduce

1. Open a page and bookmark it.
2. Tap on "Edit" from the snackbar.
3. Edit the "Name", then tap on the folder to select where to save the new bookmark.
4. After selecting in which folder to save, tap the back arrow and observe.

Expected behavior

The edited name is still displayed.

Actual behavior

The edited name is not saved. If the page had a name, that one is displayed, if it didn't, the "Name" section is blank.

Device information

• Android device: Google Pixel (Android 10), Google Pixel 3A (Android 9)
• Fenix version: Beta 3.2.0-beta.1, 01/22 Nightly build

┆Issue is synchronized with this Jira Task

[sv-sdeiac]

The same issue is reproducible also editing the bookmark folder name using the same steps as in the description.

Device:

• Samsung Galaxy Tab S3 (Android 8).
• Fenix version: Beta 3.2.0-beta.1

[juan-goncalves]

I'd like to work on this issue, is it still available?

[ekager]

Yep! Go for it @juan-goncalves

[juan-goncalves]

As the EditBookmarkFragment onViewCreated method loads the bookmark data from a PlacesBookmarkStorage, when we navigate to another screen and return, the view is recreated and the onViewCreated method is triggered once again, querying the bookmark storage and updating the fragment's EditTexts with the saved values, losing the user's input.

A simple fix would be to compare the bookmark node from storage with the one that the fragment already had a reference to (in the bookmarkNode attribute), updating the EditTexts only if they are effectively different.

Currently they would only be different when the fragment is created the first time, as the bookmarkNode would be null and after fetching it from the storage it would have some other value. When we are navigating back to the fragment, its bookmarkNode will already have a reference to a bookmark, so the EditTexts won't be updated.

[sflorean]

Verified as fixed on Nightly 5/19 and 5.1-beta.1 builds.
Devices: Nokia 6 (Android 7.1.1), Samsung Galaxy Note 10 (Android 10), Xiaomi Mi Pad 2 (Android 5.1).