Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Option to choose a top nav bar #5694

Closed
4 tasks done
vesta0 opened this issue Oct 1, 2019 · 13 comments
Closed
4 tasks done

Option to choose a top nav bar #5694

vesta0 opened this issue Oct 1, 2019 · 13 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Toolbar Address bar, see also Feature:Search needs:strings Needs strings
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 1, 2019

User Story

  • As a user who is used to a top nav bar, I want the option to move the nav bar to the top, so I can interact with my browser easily and comfortably.

This user story is the result of UX research, design discussions, and recommendations that took place in Q3.

Added benefit: top nav bar can auto-hide when scrolling

Dependency:

#4281 Need to remove QAB first

Acceptance Criteria

  • I can do go into settings and choose to move the nav bar to the top (default is bottom nav)
  • Once I have changed my setting, the nav bar moves to the top
  • Navbar will auto-hide when scrolling (this used to be possible when we had this at the top)
  • Make sure nav bar is still pinned (doesn't autohide) and works properly when using Custom Tabs

UX

Abstract: Screens 13 & 14 - https://share.goabstract.com/7cd59d53-ad3a-4b33-8131-74703c1859a2

┆Issue is synchronized with this Jira Task

@tom-james-watson
Copy link

It sounds like choosing a top nav bar would make the nav bar auto-hide. I personally want a top nav bar but without auto-hiding. Can we make the nav bar position and whether or not to auto-hide two different options? Thanks!

@Wazhai
Copy link

Wazhai commented Oct 1, 2019

Is there a reason why the bottom nav bar can't auto-hide as well?

@uniquePWD
Copy link

@imchau they're working on it. It needs some GeckoView work.

@dylmye
Copy link

dylmye commented Oct 1, 2019

@tom-james-watson perhaps auto-hiding would be a separate option from the position of the nav bar.

Either way a definite +1 for this PR so I can use fenix :)

@monreal
Copy link

monreal commented Oct 7, 2019

I wondered about the auto hiding of the bottom navbar as well initially. Then I realized the constantly shown bar is what I like about Fenix. That is because the bar is needed for tab management.

@lime124
Copy link
Collaborator

lime124 commented Oct 10, 2019

designs being wrapped up and should be finished by end of sprint tomorrow (Friday).

@apbitner apbitner added the eng:ready Ready for engineering label Oct 11, 2019
@apbitner apbitner removed their assignment Oct 11, 2019
@vesta0 vesta0 added the E5 Estimation Point: about 5 days label Oct 16, 2019
@abatishchev
Copy link

@lime124 how the final design looks like? Does it include two separate options: position and whether to auto-hide?

@lime124
Copy link
Collaborator

lime124 commented Oct 24, 2019

@abatishchev the scope of this ticket was limited to selecting the position of the nav bar. thanks!
Screen Shot 2019-10-24 at 3 33 41 PM

@dylmye
Copy link

dylmye commented Oct 25, 2019

@abatishchev see #4383 which is tracking the auto-hide feature

@martinlanger90
Copy link

can I already use a dev .apk :-)???

@liuche liuche added this to the v3.0 milestone Oct 25, 2019
@sblatz sblatz added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Nov 5, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Nov 15, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Nov 15, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Nov 22, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Nov 25, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Nov 25, 2019
boek pushed a commit that referenced this issue Nov 26, 2019
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
@sblatz sblatz added the eng:qa:needed QA Needed label Nov 26, 2019
@lobontiumira
Copy link

Verified as fixed on the latest Nightly builds from 11/27 (#13310607, #13310606) with Samsung Galaxy Note 8 (Android 9), and HTC Desire 820 (Android 6.0.1).
Verified that:

  • the user can move the navigation bar to the top (default is bottom nav) from Settings - Toolbar,
  • once the setting is done, the navigation bar moves to the top,
  • the navigation bar will auto-hide when scrolling,
  • the navigation bar is still pinned (doesn't autohide) and works properly when using custom tabs.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 27, 2019
@tom-james-watson
Copy link

Nice to see great progress being made on this. There does, however, seem to be a pretty big flaw with the current implementation.

I have set the toolbar to show at the top, which works as expected:

image

However, the nav bar still appears at the bottom in the tab overview page:

image

This is obviously quite inconsistent and jarring. Seems like hopefully quite an easy fix?

@cadeyrn
Copy link
Contributor

cadeyrn commented Nov 27, 2019

@tom-james-watson that's #6820.

@liuche liuche modified the milestones: v3.1, v3.0 Dec 7, 2019
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 5, 2020
ekager pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 6, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 6, 2020
ekager pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Toolbar Address bar, see also Feature:Search needs:strings Needs strings
Projects
None yet
Development

No branches or pull requests