Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Search engines are not updated immediately after changing language #27753

Closed
Mugurell opened this issue Nov 8, 2022 · 2 comments · Fixed by #27793, C-EO/fenix#4, nathanmkaya/fenix#108 or fork-house/fenix#14
Closed

[Bug]: Search engines are not updated immediately after changing language #27753

Mugurell opened this issue Nov 8, 2022 · 2 comments · Fixed by #27793, C-EO/fenix#4, nathanmkaya/fenix#108 or fork-house/fenix#14
Assignees
@DreVla
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search Feature:SearchProvider needs:triage Issue needs triage
Milestone
109

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Nov 8, 2022 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Change language from system language or app settings
  2. Check the available search engines

Expected behaviour

The list of available search engines is automatically updated for the newly selected locale

Actual behaviour

An app restart is needed for the list of search engines to be updated.
The issues happens with or without unified search enabled.

Firefox version

Seems like an old issue, happens in the current release also.

Additional information

SlowSearchEngines.mp4

┆Issue is synchronized with this Jira Task
┆Link To Issue: https://mozilla-hub.atlassian.net/browse/FNXV2-21950
@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. Feature:SearchProvider Feature:Search needs:triage Issue needs triage labels Nov 8, 2022
DreVla added a commit to DreVla/fenix that referenced this issue Nov 10, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
75c53d8 
…anging language
DreVla added a commit to DreVla/fenix that referenced this issue Nov 10, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
111a7ab 
…anging system language
@github-actions github-actions bot mentioned this issue Nov 10, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 10, 2022
DreVla added a commit to DreVla/fenix that referenced this issue Nov 11, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
e000700 
…anging language
DreVla added a commit to DreVla/fenix that referenced this issue Nov 11, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
03ec1f4 
…anging system language
DreVla added a commit to DreVla/fenix that referenced this issue Nov 23, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
81cd824 
…anging language
DreVla added a commit to DreVla/fenix that referenced this issue Nov 23, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
189c91c 
…anging system language
DreVla added a commit to DreVla/fenix that referenced this issue Dec 5, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
512d79f 
…anging language
DreVla added a commit to DreVla/fenix that referenced this issue Dec 5, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
b25739f 
…anging system language
DreVla added a commit to DreVla/fenix that referenced this issue Dec 5, 2022
@DreVla
For mozilla-mobile#27753: Fix verifySearchEnginesWithRTLLocale UI test
2c58592
DreVla added a commit to DreVla/fenix that referenced this issue Dec 6, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
48539bd 
…anging language
DreVla added a commit to DreVla/fenix that referenced this issue Dec 6, 2022
@DreVla
For mozilla-mobile#27753 - Update search engines immediately after ch…
8fe88a9 
…anging system language
mergify bot pushed a commit that referenced this issue Dec 6, 2022
@DreVla @mergify
For #27753 - Update search engines immediately after changing language
807b056
mergify bot pushed a commit that referenced this issue Dec 6, 2022
@DreVla @mergify
For #27753 - Update search engines immediately after changing system …
80a1708 
…language
@mergify mergify bot closed this as completed in #27793 Dec 6, 2022
@github-actions github-actions bot reopened this Dec 6, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Dec 6, 2022
@github-actions github-actions bot added this to the 109 milestone Dec 6, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 109.0a1 (2022-12-07) build.
The search engines are updated immediately when switching for a different language.
Device used: Google Pixel 4 (Android 13).
Closing the ticket as fixed.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 7, 2022
@AdinaPetridean
Copy link

Also verified implemented on Beta 109.0b1 with Poco M4 Pro (Android 12).

This was referenced Jan 16, 2023
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@DreVla @mergify
[fenix] For mozilla-mobile/fenix#27753 - Update search engines immedi…
5c741a1 
…ately after changing language
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@DreVla @mergify
[fenix] For mozilla-mobile/fenix#27753 - Update search engines immedi…
5927fe9 
…ately after changing system language
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DreVla DreVla

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Search Feature:SearchProvider needs:triage Issue needs triage
Projects
None yet
Milestone
109
4 participants
@Mugurell @DreVla @SoftVision-LorandJanos @AdinaPetridean