Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: search bar becomes very small after fold from large to small screen #27540

Closed
Yourhopegaming opened this issue Oct 25, 2022 · 7 comments · Fixed by #28037, C-EO/fenix#4, #28100, fork-house/fenix#14 or nathanmkaya/fenix#108
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone

Comments

@Yourhopegaming
Copy link

Yourhopegaming commented Oct 25, 2022

Steps to reproduce

  1. Obtain foldable device (occurs 100% of the time on fold 4)
  2. Open Firefox in unfolded mode and open a website (only happens if app is started in unfolded mode)
  3. Close phone
  4. Search bar is now the wrong size

Expected behaviour

The search bar should resize to the proper size as if app is opened in folded mode

Actual behaviour

The searchbar is very small, with the lock icon detailing website security taking up most of the space. Upon clicking on visible part of searchbar (not very easy), original size and function is restored and now works properly when folded

Device name

Samsung Galaxy Z Fold 4

Android version

Android 12L/13

Firefox release type

Firefox

Firefox version

106.1.0

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task

@Yourhopegaming Yourhopegaming added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Oct 25, 2022
@Yourhopegaming Yourhopegaming changed the title [Bug]: search bar becomes very small after fold from large to small creen [Bug]: search bar becomes very small after fold from large to small screen Oct 25, 2022
@Yourhopegaming
Copy link
Author

Yourhopegaming commented Oct 25, 2022

What it looks like
Screenshot_20221025_092813_Firefox
What it should look like
Screenshot_20221025_092821_Firefox

@mcarare
Copy link
Contributor

mcarare commented Oct 25, 2022

This is likely from this. We should investigate how to handle foldable devices in this scenario.

@zmckenney zmckenney self-assigned this Nov 30, 2022
zmckenney pushed a commit to zmckenney/fenix that referenced this issue Nov 30, 2022
zmckenney pushed a commit to zmckenney/fenix that referenced this issue Nov 30, 2022
zmckenney pushed a commit to zmckenney/fenix that referenced this issue Nov 30, 2022
zmckenney pushed a commit to zmckenney/fenix that referenced this issue Nov 30, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 30, 2022
zmckenney pushed a commit to zmckenney/fenix that referenced this issue Dec 2, 2022
@mergify mergify bot closed this as completed in #28037 Dec 2, 2022
@github-actions github-actions bot added this to the 109 milestone Dec 2, 2022
@github-actions github-actions bot reopened this Dec 2, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Dec 2, 2022
zmckenney pushed a commit to zmckenney/fenix that referenced this issue Dec 6, 2022
…null crash and invalidating actions when modifying toolbar
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 6, 2022
@zmckenney
Copy link

Reopened due to issue with BrowserFragment calling a null toolbar when BaseBrowserFragment has not initialized the UI or toolbar. Bugzilla 1804107 ticket here with STR.

@mergify mergify bot closed this as completed in #28100 Dec 7, 2022
@github-actions github-actions bot reopened this Dec 7, 2022
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 7, 2022
@SoftVision-LorandJanos
Copy link

@Yourhopegaming, we do not yet have foldable devices.
Could you check if the issue is reproducible for you with the latest Nightly build?
Thank you!

@zmckenney
Copy link

@SoftVision-LorandJanos This can also be tested on tablets which support multitasking (such as most Samsung tablets now). Putting 2 apps side by side and changing the dimensions of Fenix when opened should work correctly.

Also, I use a foldable device (Samsung ZFold3) as my daily driver but @Yourhopegaming if you can confirm it working as well that'd be great! 😃

@Yourhopegaming
Copy link
Author

@SoftVision-LorandJanos @zmckenney It appears that it is working in Nightly thanks for your help for fixing this issue it was very annoying. Sorry for the late reply

@sv-amocirean
Copy link

Hello!
Using a Folded Device Emulator in Android Studio with Android 13, the issue is not occurring in Firefox 109.0b1 or Nightly 110.0a1.
Based on the results and the previous comments, I will close this issue as fixed.

Thanks!

@sv-amocirean sv-amocirean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed needs:triage Issue needs triage labels Dec 16, 2022
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.