Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Use textAccent instead of textSecondary for Learn more in wallpaper settings #27024

Closed
sarah541 opened this issue Sep 15, 2022 · 3 comments · Fixed by #26992 or fork-house/fenix#13
Closed

Use textAccent instead of textSecondary for Learn more in wallpaper settings #27024

sarah541 opened this issue Sep 15, 2022 · 3 comments · Fixed by #26992 or fork-house/fenix#13
Assignees
@sarah541
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone
106

Comments

@sarah541
Copy link
Contributor

sarah541 commented Sep 15, 2022 •
edited by data-sync-user
Loading

UX agreed to use textAccent for Learn More in the description of wallpapers on Wallpaper Settings screen instead of textSecondary

┆Issue is synchronized with this Jira Task
@sarah541 sarah541 self-assigned this Sep 15, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 15, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Sep 15, 2022
@sarah541
For mozilla-mobile#27024 - Use textAccent for the "Learn more" link i…
b9c7c3e 
…n the wallpaper settings
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 15, 2022
@github-actions github-actions bot mentioned this issue Sep 15, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #26992 Sep 15, 2022
mergify bot pushed a commit that referenced this issue Sep 15, 2022
@sarah541 @mergify
For #27024 - Use textAccent for the "Learn more" link in the wallpape…
dafe5db 
…r settings
@github-actions github-actions bot reopened this Sep 15, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 15, 2022
@github-actions github-actions bot added this to the 106 milestone Sep 15, 2022
@MatthewTighe MatthewTighe modified the milestones: 106, 107 Sep 19, 2022
@gabrielluong gabrielluong modified the milestones: 107, 106 Sep 20, 2022
@delia-pop
Copy link

Hi, @sarah541. I tested this on Nightly 107.0a1 from 09/20 with Google Pixel 6 (Android 13), but in the current version the "Learn more" link for seasonal wallpapers is not displayed.

@sarah541
Copy link
Contributor Author

Hi @delia-pop The Learn More link only shows up when the learn more url is available. As to when the url will be available, @Kate-Galetski @MatthewTighe will be a better person to reach out.

@delia-pop delia-pop mentioned this issue Sep 21, 2022
Closed
@delia-pop
Copy link

Verified as fixed on Nightly 107.0a1 from 09/22 with Google Pixel 6 (Android 13). The "Learn more" link is displayed as required and tapping on it opens the following SUMO page: https://www.mozilla.org/en-US/stories/joy-of-color

LearnMore

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 22, 2022
@github-actions github-actions bot mentioned this issue Oct 21, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@sarah541 @mergify
[fenix] For mozilla-mobile/fenix#27024 - Use textAccent for the "Lear…
8dfd58c 
…n more" link in the wallpaper settings
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarah541 sarah541

Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Milestone
106
4 participants
@gabrielluong @MatthewTighe @sarah541 @delia-pop