Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Correct Padding between heading and wallpaper on Wallpaper Settings screen #27020

Closed
sarah541 opened this issue Sep 15, 2022 · 1 comment · Fixed by #27019 or fork-house/fenix#13
Closed

Correct Padding between heading and wallpaper on Wallpaper Settings screen #27020

sarah541 opened this issue Sep 15, 2022 · 1 comment · Fixed by #27019 or fork-house/fenix#13
Assignees
@sarah541
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone
106

Comments

@sarah541
Copy link
Contributor

sarah541 commented Sep 15, 2022 •
edited by data-sync-user
Loading

In line wallpaper heading and the wallpaper so they both have the same 16dp padding from start.
Current behavior :
image

┆Issue is synchronized with this Jira Task
@sarah541 sarah541 self-assigned this Sep 15, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 15, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Sep 15, 2022
@sarah541
For mozilla-mobile#27020 - Correct padding for wallpaper thumbnails
cd40f18
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 15, 2022
@github-actions github-actions bot mentioned this issue Sep 15, 2022
Merged
4 tasks
sarah541 added a commit to sarah541/fenix that referenced this issue Sep 15, 2022
@sarah541
For mozilla-mobile#27020 - Correct padding for wallpaper thumbnails
c3276c6
@mergify mergify bot closed this as completed in #27019 Sep 15, 2022
mergify bot pushed a commit that referenced this issue Sep 15, 2022
@sarah541 @mergify
For #27020 - Correct padding for wallpaper thumbnails
924f000
@github-actions github-actions bot added this to the 106 milestone Sep 15, 2022
@github-actions github-actions bot reopened this Sep 15, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 15, 2022
@MatthewTighe MatthewTighe modified the milestones: 106, 107 Sep 19, 2022
@gabrielluong gabrielluong modified the milestones: 107, 106 Sep 20, 2022
@delia-pop
Copy link

Verified as fixed on Nightly 107.0a1 from 09/23.
1663915956083

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 23, 2022
@github-actions github-actions bot mentioned this issue Oct 21, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@sarah541 @mergify
[fenix] For mozilla-mobile/fenix#27020 - Correct padding for wallpape…
2cc5d78 
…r thumbnails
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarah541 sarah541

Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Milestone
106
4 participants
@gabrielluong @MatthewTighe @sarah541 @delia-pop