Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Recent tab thumbnail and icon not using correct content scale #26666

Closed
rocketsroger opened this issue Aug 26, 2022 · 1 comment · Fixed by #26653 or nathanmkaya/fenix#108
Closed

Recent tab thumbnail and icon not using correct content scale #26666

rocketsroger opened this issue Aug 26, 2022 · 1 comment · Fixed by #26653 or nathanmkaya/fenix#108
Assignees
@rocketsroger
Labels
eng:qa:verified QA Verified
Milestone
106

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Aug 26, 2022 •
edited by data-sync-user
Loading

Currently we're not using the correct content scale in thumbnail and icon. This could be an issue when the image or icon doesn't have the right ratio or size.

┆Issue is synchronized with this Jira Task
@rocketsroger rocketsroger self-assigned this Aug 26, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 26, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Aug 26, 2022
@rocketsroger
Close mozilla-mobile#26666: Use correct content scale when displaying…
16b974b 
… recent tab thumbnail and icon
@github-actions github-actions bot mentioned this issue Aug 26, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 26, 2022
@rocketsroger rocketsroger removed the needs:triage Issue needs triage label Aug 26, 2022
@mergify mergify bot closed this as completed in #26653 Aug 26, 2022
mergify bot pushed a commit that referenced this issue Aug 26, 2022
@rocketsroger @mergify
Close #26666: Use correct content scale when displaying recent tab th…
da06df4 
…umbnail and icon
@github-actions github-actions bot added this to the 106 milestone Aug 26, 2022
@github-actions github-actions bot reopened this Aug 26, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 26, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Fenix Nightly 106.0a1 (2022-09-01) using the step provided here #26653 (comment). After loading the https://www.apple.com/ website and restarting Fenix the thumbnail and icon are displayed correctly.

1662132208875

Devices used:

  • Google Pixel 6 (Android 13)
  • Samsung Galaxy S22 Ultra (Android 12)
  • OnePlus 6T (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 2, 2022
@github-actions github-actions bot mentioned this issue Sep 21, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
106
2 participants
@rocketsroger @LaurentiuApahideanSV