Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Extract homescreen synced tabs into its own viewholder #26421

Closed
sarah541 opened this issue Aug 10, 2022 · 1 comment · Fixed by #26422 or nathanmkaya/fenix#108
Closed

Extract homescreen synced tabs into its own viewholder #26421

sarah541 opened this issue Aug 10, 2022 · 1 comment · Fixed by #26422 or nathanmkaya/fenix#108
Assignees
@sarah541
Labels
eng:qa:verified QA Verified performance Possible performance wins
Milestone
105

Comments

@sarah541
Copy link
Contributor

sarah541 commented Aug 10, 2022 •
edited
Loading

As of now, recent synced tabs come under the same view holder as recent tabs (jump back in).
Separating into it's own view holder will help with easier use of it

Design : https://www.figma.com/file/hJfV1KGZuOK7OYr29pooL5/Synced-tabs?node-id=69%3A6540

┆Issue is synchronized with this Jira Task
@sarah541 sarah541 added the performance Possible performance wins label Aug 10, 2022
@sarah541 sarah541 self-assigned this Aug 10, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 10, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Aug 10, 2022
@sarah541
For mozilla-mobile#26421 - Extract synced tabs into it's own viewholder
5cc7efb
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 10, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Aug 11, 2022
@sarah541
For mozilla-mobile#26421 - Extract synced tabs into it's own viewholder
c671935
sarah541 added a commit to sarah541/fenix that referenced this issue Aug 11, 2022
@sarah541
For mozilla-mobile#26421 - Extract synced tabs into it's own viewholder
d83e030
sarah541 added a commit to sarah541/fenix that referenced this issue Aug 15, 2022
@sarah541
For mozilla-mobile#26421 - Extract synced tabs into it's own viewholder
dcde06b
sarah541 added a commit to sarah541/fenix that referenced this issue Aug 15, 2022
@sarah541
For mozilla-mobile#26421 - Extract synced tabs into it's own viewholder
9fe7f0e
sarah541 added a commit to sarah541/fenix that referenced this issue Aug 16, 2022
@sarah541
For mozilla-mobile#26421 - Extract synced tabs into it's own viewholder
8f75238
@mergify mergify bot closed this as completed in #26422 Aug 16, 2022
mergify bot pushed a commit that referenced this issue Aug 16, 2022
@sarah541 @mergify
For #26421 - Extract synced tabs into it's own viewholder
0b0e31a
@github-actions github-actions bot added this to the 105 milestone Aug 16, 2022
@github-actions github-actions bot reopened this Aug 16, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 16, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox Nightly and the synced tab is into it's own viewholder.
Screenshot_20220817-175746
Screenshot_20220817-175936_Firefox Nightly~2

Devices used:

  • Google Pixel 6 (Android 13)
  • Samsung Galaxy S22 Ultra (Android 12)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 17, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Aug 19, 2022
@github-actions github-actions bot mentioned this issue Sep 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarah541 sarah541

Labels
eng:qa:verified QA Verified performance Possible performance wins
Projects
None yet
Milestone
105
3 participants
@gabrielluong @sarah541 @LaurentiuApahideanSV