Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Have the Pocket sponsored feature be part of the homescreen experiments #26414

Closed
Mugurell opened this issue Aug 10, 2022 · 2 comments · Fixed by #26416 or nathanmkaya/fenix#108
Closed

Have the Pocket sponsored feature be part of the homescreen experiments #26414

Mugurell opened this issue Aug 10, 2022 · 2 comments · Fixed by #26416 or nathanmkaya/fenix#108
Assignees
@Mugurell
Labels
eng:qa:verified QA Verified Feature:PocketIntegration
Milestone
105

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Aug 10, 2022 •
edited by data-sync-user
Loading

Currently the Pocket sponsored feature is a Nimbus feature on it's own - https://github.com/mozilla-mobile/fenix/blob/main/.experimenter.yaml#L61.

It would make more sense to have the feature be part of the other homescreen sections already controllable through Nimbus -

fenix/.experimenter.yaml

Lines 18 to 20 in f356df7

sections-enabled:
type: json
description: "This property provides a lookup table of whether or not the given section should be enabled. If the section is enabled, it should be toggleable in the settings screen, and on by default."

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Aug 10, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 10, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 10, 2022
@Mugurell
For mozilla-mobile#26414 - Have the Pocket spocs feature as part of t…
24959f9 
…he homescreen sections experiments
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 10, 2022
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
4 tasks
Mugurell added a commit to Mugurell/fenix that referenced this issue Aug 12, 2022
@Mugurell
For mozilla-mobile#26414 - Have the Pocket spocs feature as part of t…
087e40d 
…he homescreen sections experiments
@amedyne amedyne removed the needs:triage Issue needs triage label Aug 15, 2022
mergify bot pushed a commit that referenced this issue Aug 16, 2022
@Mugurell @mergify
For #26414 - Have the Pocket spocs feature as part of the homescreen …
f96f846 
…sections experiments
@mergify mergify bot closed this as completed in #26416 Aug 16, 2022
@github-actions github-actions bot added this to the 105 milestone Aug 16, 2022
@github-actions github-actions bot reopened this Aug 16, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 16, 2022
@Mugurell
Copy link
Contributor Author

@ QA: For the moment we could test that the feature functions as before in debug. (it should still only be available in debug)

@SoftVision-LorandJanos
Copy link

Tested with the latest debug build (GV: 105.0a1-20220817091029).
Device used: Google Pixel 4 (Android 12).
Closing the ticket as fixed, and marking it as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 18, 2022
@github-actions github-actions bot mentioned this issue Sep 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
eng:qa:verified QA Verified Feature:PocketIntegration
Projects
None yet
Milestone
105
3 participants
@Mugurell @SoftVision-LorandJanos @amedyne