Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor the search widget to use the A-C common behaviour #26329

Closed
iorgamgabriel opened this issue Aug 5, 2022 · 3 comments
Closed

Refactor the search widget to use the A-C common behaviour #26329

iorgamgabriel opened this issue Aug 5, 2022 · 3 comments
Assignees
@iorgamgabriel
Labels
eng:qa:not-needed Added by QA to issues that cannot be tested needs:triage Issue needs triage

Comments

@iorgamgabriel
Copy link
Contributor

iorgamgabriel commented Aug 5, 2022 •
edited by data-sync-user
Loading

This task should contain the implementation of search widget the Fenix part. I moved and refactored the search widget from Fenix in AC .
This has appear based on this mozilla-mobile/focus-android#7249 (comment)
This is the task from AC mozilla-mobile/android-components#12565 .
This is the task from Focus mozilla-mobile/focus-android#7249

┆Issue is synchronized with this Jira Task
@iorgamgabriel iorgamgabriel self-assigned this Aug 5, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 5, 2022
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 5, 2022
@iorgamgabriel
For mozilla-mobile#26329 Implement the search widget Fenix part
e5943d5
@github-actions github-actions bot mentioned this issue Aug 5, 2022
Closed
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 5, 2022
@iorgamgabriel iorgamgabriel changed the title Implement the search widget Fenix part Refactor the search widget to use the A-C common behaviour Aug 8, 2022
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 8, 2022
@iorgamgabriel
For mozilla-mobile#26329 Implement the search widget Fenix part
1ecfe6d
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 8, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
77c2e74 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 8, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
8a016cd 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 9, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
2e31d05 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 9, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
75cc0b6 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 10, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
6978990 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 16, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
9751be9 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 18, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
69e3aa2 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 18, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
fbdcfb2 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 18, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
5494021 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 18, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
1fa66d4 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 18, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
97209e0 
…mmon behaviour
iorgamgabriel added a commit to iorgamgabriel/fenix that referenced this issue Aug 18, 2022
@iorgamgabriel
For mozilla-mobile#26329 Refactor the search widget to use the A-C co…
f83add6 
…mmon behaviour
@csadilek
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1813191

Change performed by the Move to Bugzilla add-on.

@github-actions github-actions bot reopened this Jan 27, 2023
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jan 27, 2023
@delia-pop
Copy link

Removing the QA needed label and adding QA not Needed here instead.

@delia-pop delia-pop added eng:qa:not-needed Added by QA to issues that cannot be tested and removed eng:qa:needed QA Needed labels Jan 30, 2023
@iorgamgabriel
Copy link
Contributor Author

#26331 (comment) based on this comment this is not needed any more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iorgamgabriel iorgamgabriel

Labels
eng:qa:not-needed Added by QA to issues that cannot be tested needs:triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #26329 Refactor the search widget to use the A-C common behaviour iorgamgabriel/fenix
3 participants
@csadilek @iorgamgabriel @delia-pop