Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Clicking wallpaper thumbnails should download the full version. #26212

Closed
MatthewTighe opened this issue Jul 27, 2022 · 2 comments · Fixed by #26671, fork-house/fenix#13 or nathanmkaya/fenix#108
Assignees
Milestone

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Jul 27, 2022

If a wallpaper thumbnail isn't downloaded when clicked, it should be downloaded.

  • When a wallpaper is clicked a loading indicator should be shown and the thumbnail opacity should be set to 50% while the wallpaper downloads.
  • When a wallpaper is finished downloading it should be shown normally

Note: this is specifically for the settings page but should be done such that it can be easily copied into the upcoming wallpaper onboarding card. This means exposing a click handler or something similar so that the home screen can update its view with the newly selected wallpaper. This is dependent on #26211

┆Issue is synchronized with this Jira Task

@MatthewTighe MatthewTighe self-assigned this Jul 27, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 27, 2022
@MatthewTighe MatthewTighe removed the needs:triage Issue needs triage label Jul 27, 2022
@MatthewTighe MatthewTighe changed the title Clicking wallpaper thumbnails should download them. Clicking wallpaper thumbnails should download the full version. Jul 27, 2022
@MatthewTighe MatthewTighe removed their assignment Aug 22, 2022
@MatthewTighe
Copy link
Contributor Author

Note that the underlying functionality to download a wallpaper on click will be added in https://github.com/mozilla-mobile/fenix/pull/26562/files

This ticket is about responding to changes in wallpaper.assetsFileState appropriately to show the loading indicator and opacity.

@mcarare mcarare assigned MatthewTighe and unassigned MatthewTighe Aug 24, 2022
@mavduevskiy mavduevskiy self-assigned this Aug 26, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 26, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 26, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 29, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 31, 2022
…ror snackbars, fix snackbars staying longer than expected
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 6, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 6, 2022
…ror snackbars, fix snackbars staying longer than expected
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 6, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 6, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 6, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 12, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 12, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 13, 2022
@mergify mergify bot closed this as completed in #26671 Sep 13, 2022
@github-actions github-actions bot added this to the 106 milestone Sep 13, 2022
@github-actions github-actions bot reopened this Sep 13, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 13, 2022
@MatthewTighe MatthewTighe modified the milestones: 106, 107 Sep 19, 2022
@gabrielluong gabrielluong modified the milestones: 107, 106 Sep 20, 2022
@delia-pop
Copy link

Verified as fixed on Nightly 107.0a1 from 09/20 with Google Pixel 6 (Android 13). When tapping on the wallpaper thumbnails, a loading indication is displayed and the thumbnail opacity changes during the download. The wallpaper is correctly displayed after download.

26212.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.