Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Pocket sponsored stories rotation and pacing #25281

Closed
Mugurell opened this issue May 18, 2022 · 1 comment
Closed

Pocket sponsored stories rotation and pacing #25281

Mugurell opened this issue May 18, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented May 18, 2022

Needs mozilla-mobile/android-components#12184

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell self-assigned this May 18, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label May 18, 2022
@Mugurell Mugurell removed the needs:triage Issue needs triage label May 25, 2022
mergify bot pushed a commit that referenced this issue May 26, 2022
A new way to be able to reliably record actual impressions of sponsored stories
was needed and based on this data we can ensure we are promoting fresh stories
(with fewer impressions) or the ones with a higher priority.
mergify bot pushed a commit that referenced this issue May 26, 2022
…essions

Currently just a hack that will ensure more reliable data.
This will have to be re-evaluated after the homescreen is migrated to compose.
mergify bot pushed a commit that referenced this issue May 26, 2022
The toolbar may appear over the Pocket stories causing our functionality for
reporting when a specific story is visible to misreport.
At the moment hardcoding the toolbar height in the visibility checks seems like
the best solution to ensure reliable data.
mergify bot pushed a commit that referenced this issue May 26, 2022
This fixes the following two scenarios resulting in improper recordings:
- sponsored stories were recorded as shown as part of the impressions recording
for all the stories (both recommended and sponsored). Separated the two.
- sponsored stories were not recorded as shown if the user doesn't scroll.
This could happen if just toggling categories which would result in a new list
of stories to show. Will recheck after the time to settle if the composable is
shown.
@Mugurell
Copy link
Contributor Author

Since this is hidden in debug I'll set qa:not-needed for now.

@Mugurell Mugurell added the eng:qa:not-needed Added by QA to issues that cannot be tested label May 27, 2022
@Mugurell Mugurell added this to the 102 milestone May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant