Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

harmonize history and bookmarks style in library #2435

Closed
7 of 11 tasks
cadeyrn opened this issue May 11, 2019 · 9 comments
Closed
7 of 11 tasks

harmonize history and bookmarks style in library #2435

cadeyrn opened this issue May 11, 2019 · 9 comments
Labels
eng:ready Ready for engineering feature request 🌟 New functionality and improvements Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented May 11, 2019 •
edited by data-sync-user
Loading

It's more polish than a feature request. The feature request label was automatically added because I accidentally used an issue template.

History and bookmarks are both part of the library but there are a few visual differences that should be eliminated so that the overall picture is consistent.

What / Requirements

  • Show url for bookmarks
  • unify spacing
  • Add additional options to the History item menu (Copy, Share, Open in new tab, Open in private tab, Delete)
  • Replace the edit with a share icon in top bar on Bookmarks multi-select view to match History

More details

  1. List view:

fenixUNITO-UNDERSCORE!1!

There are three obvious differences:

  • FIXED - a) Both views have a different icon style. This should be unified in any case.
  • FIXED - b) The history shows URLs, bookmarks not. Fennec and Chrome both shows the URLs also for bookmarks so I vote for doing the same.
  • FIXED - c) There is another difference: In the history the menu icons of the items are below the [x] icon in the toolbar. In the bookmarks view the position is too far left.
  • FIXED - d) I also suggest to reduce the spacing between the page title and the URL similar to the spacing on the tabs view on the home screen.
  1. Menu:

fenixUNITO-UNDERSCORE!2!

  • a) The menu in the history has only a "Delete" menu item, the menu in the bookmarks view has a few more. "Edit" and "Copy" make no sense in history, but all others make sense in both menus: Select, Share, Open in new tab, Open in private tab. These items should either be in history AND bookmarks or in none of them.
  1. Multi select:

fenixUNITO-UNDERSCORE!3!

There are two obvious differences:

  • FIXED - a) Both views have a different checkmark style. This should be unified in any case.
  • b) The toolbar in the history has a share icon, the toolbar in the bookmarks view a edit icon. First I thought this difference is okay because edit as primary action makes sense in the bookmarks view. But then I noticed that you can't edit more than one bookmark at the same time. Once you select two bookmarks the edit icon disappears. So a edit icon as action in the multi select view doesn't make sense at all because if you only want to edit one bookmark you won't use the multi select mode. So this should probably be changed to the share icon. This will work for more than one tab (according to Add "Share Tabs" functionality to share icon in history fragment #2377) and would be consistent with the history view.

┆Issue is synchronized with this Jira Task
@cadeyrn cadeyrn added the feature request 🌟 New functionality and improvements label May 11, 2019
@cadeyrn cadeyrn mentioned this issue May 13, 2019
Closed
@vesta0 vesta0 added the needs:UX-feedback Needs UX Feedback label May 14, 2019
@vesta0 vesta0 added this to the Post-MVP Backlog milestone May 14, 2019
@vesta0 vesta0 added the P2 Upcoming release label May 14, 2019
@cadeyrn cadeyrn mentioned this issue May 16, 2019
Closed
@buttercookie42 buttercookie42 mentioned this issue May 17, 2019
Closed
@boek
Copy link
Contributor

boek commented May 20, 2019

@topotropic could you take a look at #2435? :)

@topotropic
Copy link

Thanks @cadeyrn for the feedback!

1b) I agree that showing the URL for bookmarks might add helpful information.
1d) I'll look into the spacing issues.
2a) Makes sense to add additional options to the History item menu (Copy, Share, Open in new tab, Open in private tab, Delete)
3b) Yes, sounds reasonable to replace the edit with a share icon in top bar on Bookmarks multi-select view

@cadeyrn
Copy link
Contributor Author

cadeyrn commented May 20, 2019

For 1b and 1d I already created PRs with screnshots for comparison: #2580 and #2626.

@topotropic topotropic added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels May 22, 2019
boek pushed a commit that referenced this issue May 23, 2019
@cadeyrn @boek
For #2435 - adds URL to bookmarks in library
cc03aeb
@cadeyrn cadeyrn mentioned this issue Jul 1, 2019
Merged
@vesta0 vesta0 removed P2 Upcoming release labels Jul 2, 2019
@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@buttercookie42 buttercookie42 mentioned this issue Aug 19, 2019
Closed
@liuche liuche added Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue. labels Oct 5, 2019
@obarzpaw
Copy link
Contributor

obarzpaw commented Oct 7, 2019

I would like to work on this

@Dunexus Dunexus mentioned this issue Oct 7, 2019
Closed
obarzpaw added a commit to obarzpaw/fenix that referenced this issue Oct 19, 2019
@obarzpaw
Closes mozilla-mobile#2435 Change edit icon to share icon on the book…
dd573d6 
…mark toolbar
@obarzpaw
Copy link
Contributor

@NotWoods @boek @cadeyrn

I've changed icon on the bookmark toolbar and create PR for that bug.

And after merge I can fix the last one bug in the seperate PR.

obarzpaw added a commit to obarzpaw/fenix that referenced this issue Oct 21, 2019
@obarzpaw
Closes mozilla-mobile#2435 Changed raw string to string resources
2509562
obarzpaw added a commit to obarzpaw/fenix that referenced this issue Oct 22, 2019
@obarzpaw
Closes mozilla-mobile#2435 add orEmpty
8bb7c5e
bors bot pushed a commit that referenced this issue Oct 22, 2019
@MozLando @obarzpaw
Merge #6137
6d8171b 
6137: Closes #2435 Change edit icon to share icon on the book… r=NotWoods a=obarzpaw

Changed icon on the bookmark toolbar from edit icon to share icon

<img src="https://user-images.githubusercontent.com/50130354/67178570-882fe500-f3d3-11e9-8cfb-c98cf9e14d54.png" width="270" height="480">



Co-authored-by: obarzpaw <[email protected]>
@sblatz sblatz closed this as completed in 40cda1d Oct 22, 2019
mcarare pushed a commit to mcarare/fenix that referenced this issue Oct 29, 2019
@obarzpaw @mcarare
Closes mozilla-mobile#2435 Change edit icon to share icon on the book… (
9fe3ec2 
mozilla-mobile#6137)

* Closes mozilla-mobile#2435 Change edit icon to share icon on the bookmark toolbar

* Closes mozilla-mobile#2435 Changed raw string to string resources

* Pass bookmark arguments to share fragment

* Closes mozilla-mobile#2435 add orEmpty
@ekager ekager reopened this Nov 14, 2019
@ekager
Copy link
Contributor

ekager commented Nov 14, 2019

Reopening because a few of these items in the checklist were not completed. ie matching the 3 dot menu options

@obarzpaw
Copy link
Contributor

I can take care about this issue one more time :)

@KaairaGupta
Copy link
Contributor

@ekager may I be assigned this?
I have noticed two of the requested features missing in the latest master and would like to work on those, they are:

  • matching the three-dot menu
  • though the bookmark shows 'share' icon instead of 'edit' in the bookmarks tab, but it doesn't show any option on multi-selecting the bookmarks.

@topotropic
Copy link

I'll close this issue. We have follow up issues for

@data-sync-user data-sync-user changed the title harmonize history and bookmarks style in library FNX2-17995 ⁃ harmonize history and bookmarks style in library Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-17995 ⁃ harmonize history and bookmarks style in library FNX3-16322 ⁃ harmonize history and bookmarks style in library Aug 11, 2020
@cadeyrn cadeyrn closed this as completed Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16322 ⁃ harmonize history and bookmarks style in library harmonize history and bookmarks style in library May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:ready Ready for engineering feature request 🌟 New functionality and improvements Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@topotropic @liuche @cadeyrn @boek @ekager @vesta0 @KaairaGupta @obarzpaw @data-sync-user