Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fenix Settings Menu Experiment (Test_branch 2:Default Browser at #1 position, Control: Sync at #1 position) #18376

Closed
ItsDevyani opened this issue Mar 8, 2021 · 12 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Experiments A category for experiment-related features. Feature:Settings Feature:Telemetry Nimbus
Milestone

Comments

@ItsDevyani
Copy link

ItsDevyani commented Mar 8, 2021

User Story

  • As a user, I want to know how I can easily set up Fenix as my default browser when I click the settings menu.

Dependencies

Acceptance Criteria

  • Set Default Browser is the First Item on the Settings Menu (It replaces Sync)
  • We can track default browser activations coming from this source full-funnel (Clicks at each step) including conversion to default.
  • Nimbus SDK integration with Settings menu to enable testing on it.

Engineering notes

  • Nimbus engineering docs
  • This will be an A/B test for changing the card at the top of the Settings menu to "Set as default browser" (see designs)
  • The control to test against will be the "Turn on Sync" card (what we currently have in release) with a "set to default" item lower down in the settings menu:

old_design

  • Please sync with data science before starting this implementation to confirm the following:
    Experiment length: 35 days total, 7 day enrollment period
    Start date: Release with 89 (preferably)
    Experiment size: TBD
    A/B split: 50/50
    Channels: Release, Nightly
    • all of the Nimbus experiments should be pushed to nightly first. [...] Also, they don't need to go to beta afterwards but instead can go to production.

Probes
Should we use the same probe to track "set to default" clicks in both A and B states? Or should we create a different probe that is specifically for the new card?

  • If you just have the “button_clicked” event, then Glean will handle the rest of which branch they were in

  • It doesn't really matter if we have one "set to default click" probe or two. Whoever picks this up should reach out to the data science team to see what their preference is and work from there :)

Proposed probes: clicks on "Turn on sync" card (control state), clicks on "Set as default browser" card (testing state), clicks on sync pref item (testing state)

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 8, 2021
@kbrosnan kbrosnan added Feature:Settings and removed needs:triage Issue needs triage labels Mar 8, 2021
@ItsDevyani
Copy link
Author

Nicole Weber is doing the design for this. We'll see 1st drafts on 3/15.

@ItsDevyani ItsDevyani changed the title Fenix Settings Menu Change Request (Move Default Browser at #1 position in the list) Fenix Settings Menu Experiment (Test:Default Browser at #1 position, Control: Sync at #1 position) Mar 23, 2021
@Amejia481
Copy link
Contributor

Amejia481 commented Mar 24, 2021

The experiment changes completely how the "turn sync UI" looks, do we have UI mocks for the multiple states on which this setting could be? They are Authenticated, LoggedOut (the one is showing) and Authentication Problems.

image

@eliserichards eliserichards added the needs:UX-feedback Needs UX Feedback label Mar 24, 2021
@ItsDevyani
Copy link
Author

ItsDevyani commented Mar 25, 2021 via email

@topotropic
Copy link

Sure, I added the logged in state (https://www.figma.com/file/w8vFnZ05xMgDPkEb9r0r35/R89?node-id=0%3A1).

@Amejia481 what auth problems do we support here and how can I reproduce them? We don't have them documented in our existing files. Thanks!

@Amejia481
Copy link
Contributor

Thanks 😊
I think the only one is when users are signed in but they need to re-authenticate as the password has changed on another device.

image

@topotropic
Copy link

Thanks, Arturo! I added the case https://www.figma.com/file/w8vFnZ05xMgDPkEb9r0r35/R89?node-id=0%3A1

@eliserichards eliserichards removed the needs:UX-feedback Needs UX Feedback label Mar 25, 2021
@Amejia481 Amejia481 added the E3 Estimation Point: average, 2 - 3 days label Mar 25, 2021
@eliserichards eliserichards added Feature:Experiments A category for experiment-related features. Nimbus labels Mar 26, 2021
@amedyne amedyne changed the title Fenix Settings Menu Experiment (Test:Default Browser at #1 position, Control: Sync at #1 position) Fenix Settings Menu Experiment (Test_branch 2:Default Browser at #1 position, Control: Sync at #1 position) Apr 5, 2021
@amedyne
Copy link
Contributor

amedyne commented Apr 5, 2021

Note: This ticket will be for tracking the Engineering tasks for developing Experiment Test Branch 2: Set Default Browser is the First Item on the Settings Menu (It replaces Sync) and the corresponding telemetry needed for this branch.

@mcarare
Copy link
Contributor

mcarare commented Apr 13, 2021

@topotropic Should we also keep the Account preference category in order to provide some consistency for users who will be enrolled in the experiment? And also the custom user avatar (profile picture) and the yellow background for sync problems?

I've attached screenshots with these, let me know if they are ok or should I follow the mocks in Figma exactly? Thank you!

@topotropic
Copy link

Thanks, Mihai! This looks good.

@abodea
Copy link
Member

abodea commented Apr 23, 2021

I was able to verify that the changes mentioned above are in Fenix for more details please check the following:

  • The prompt with the following text Set links from websites, emails, and messages to open automatically in Firefox. is displayed at the top replacing the Turn on Sync card.

  • The Turn on Sync card moved under General with its own section.
    I was able to log in without issues and that section works as expected.
    Screenshot_20210423-151922

There are two different behaviors for the default browser:

  • When Nightly is already set as the default browser
    Screenshot_20210423-152032

  • When other browsers or none are set as default browser:
    Screenshot_20210423-151622

20210423_152756.mp4

@mcarare @ItsDevyani is this the intended behavior?
Will there be a possibility to dismiss it without setting the browser as default?
Should it disappear after setting it as default?

Regarding the issues from above, should I open new bugs?

@mcarare
Copy link
Contributor

mcarare commented Apr 23, 2021

@abodea the card goes away only if you set any firefox browser as default. The screen update is made after the preference screen is reloaded. (you navigate away and return). There are no specs regarding the possibility of dismissal with a close button like the card on the home screen.

@ItsDevyani
Copy link
Author

agreed, there is no need to have a "dismiss" action in this placement, I'm ok if it disappears and is replaced with Sync once a user has set us as default.

@sflorean sflorean closed this as completed May 6, 2021
@sflorean sflorean added the eng:qa:verified QA Verified label May 6, 2021
@gabrielluong gabrielluong added this to the 89 milestone May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Experiments A category for experiment-related features. Feature:Settings Feature:Telemetry Nimbus
Projects
None yet
Development

No branches or pull requests

10 participants