Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Make toolbar fixed in place if a11y services are enabled #18027

Closed
Mugurell opened this issue Feb 17, 2021 · 2 comments
Closed

Make toolbar fixed in place if a11y services are enabled #18027

Mugurell opened this issue Feb 17, 2021 · 2 comments
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 17, 2021

Following #17676:

  • If a user has accessibility services enabled and has not yet set the toolbar position to be at the bottom (although that is the default) or has set the toolbar position to be at the top:
    - the toolbar should be placed at top in a fixed position (this is the current behavior)
  • If a user has accessibility services enabled and has set the toolbar position to be at the bottom
    - the toolbar should be placed at the bottom in a fixed position (this is a difference to the current behavior)
  • In both cases the toolbar would be fixed in place ignoring the dynamic behavior set in app settings. (currently the a11y fixed top toolbar ignores the dynamic behavior set in app settings)

 
Eitan confirmed setting the bottom toolbar as fixed would be ok.
*When users specifically chosen the toolbar to be shown at the bottom.

I think this behavior makes sense. The one issue I can think of is that two not great things can happen when the toolbar is at the bottom with TalkBack enabled:

  1. Either the UI layout will visually show the toolbar at the bottom, but talkback swipe order will first go through the toolbar before web content. This would be inconsistent with visual layout. Or..
  2. The swipe order will correctly put content before the toolbar. The issue then would be that users who don't use explore-by-touch will need to swipe a variable and potentially large amount of times to reach the toolbar depending on what content is displayed.

Honestly, I am fine with either outcome since that would be something the user explicitly opted in for in the settings.

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:Toolbar Address bar, see also Feature:Search labels Feb 17, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 17, 2021
@Mugurell Mugurell removed the needs:triage Issue needs triage label Feb 19, 2021
@Mugurell
Copy link
Contributor Author

Starting to work on this following the spike we had in the sprint.

Mugurell added a commit that referenced this issue Feb 23, 2021
We previously only set the top toolbar as fixed if an a11y service was running.
@Mugurell Mugurell added the eng:qa:needed QA Needed label Feb 23, 2021
@Mugurell Mugurell self-assigned this Feb 25, 2021
@sflorean
Copy link
Contributor

Verified as fixed on 87.0.0-beta.1 and latest Nightly build.

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 25, 2021
@amedyne amedyne added this to the 88 milestone Feb 26, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
…a11y is enabled

We previously only set the top toolbar as fixed if an a11y service was running.
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Projects
None yet
Development

No branches or pull requests

3 participants