Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Feature] Reader view appearance controls in three-dot main menu #17971

Closed
eliserichards opened this issue Feb 11, 2021 · 1 comment
Closed

[Feature] Reader view appearance controls in three-dot main menu #17971

eliserichards opened this issue Feb 11, 2021 · 1 comment
Assignees
@mcarare
Labels
E1 Estimation Point: trivial, less than half day eng:qa:not-needed Added by QA to issues that cannot be tested Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:ReaderMode MR1 Issues that are needed for the MR1 2021 release.
Milestone
88

Comments

@eliserichards
Copy link

eliserichards commented Feb 11, 2021 •
edited by data-sync-user
Loading

Meta: #17796

UX point of contact: @violasong (Victoria)

Figma designs (bottom right, labeled "Final design"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1

Current reader view flow with "Appearance" menu item

  • Open the app
  • Navigate to a wikipedia page (anything with text)
  • See the reader view icon showing in the search toolbar
  • Select reader view
  • Open three-dot menu
  • See "Appearance" item
    image image

Acceptance criteria

  • Change "Appearance" to "Customize reader view"
  • When reader view is ON, item placement should be below "Desktop site"

image

┆Issue is synchronized with this Jira Task
@eliserichards eliserichards added the Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. label Feb 11, 2021
@eliserichards eliserichards mentioned this issue Feb 11, 2021
Closed
14 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 11, 2021
@eliserichards eliserichards added Feature:ReaderMode and removed needs:triage Issue needs triage labels Feb 11, 2021
@csadilek csadilek changed the title [Feature] Handle reader view in three-dot main menu [Feature] Handle reader view appearance controls in three-dot main menu Feb 12, 2021
@violasong
Copy link
Collaborator

Checked in with Betsy - we can change "Appearance" to "Customize reader view." I've updated the main Figma "final" mockup to reflect this :)

@eliserichards eliserichards changed the title [Feature] Handle reader view appearance controls in three-dot main menu [Feature] Reader view appearance controls in three-dot main menu Feb 18, 2021
@eliserichards eliserichards added the MR1 Issues that are needed for the MR1 2021 release. label Feb 18, 2021
@eliserichards eliserichards added the E1 Estimation Point: trivial, less than half day label Feb 23, 2021
@eliserichards eliserichards mentioned this issue Feb 24, 2021
Closed
@bifleming bifleming removed the MR1 Issues that are needed for the MR1 2021 release. label Mar 1, 2021
@amedyne amedyne added the MR1 Issues that are needed for the MR1 2021 release. label Mar 4, 2021
@mcarare mcarare self-assigned this Mar 5, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Mar 5, 2021
@mcarare
For mozilla-mobile#17971: Add Reader view appearance controls in thre…
94fb57b 
…e-dot main menu.
eliserichards pushed a commit that referenced this issue Mar 8, 2021
@mcarare
For #17971: Add Reader view appearance controls in three-dot main men…
5c7a01b 
…u. (#18340)
@eliserichards eliserichards added the eng:qa:not-needed Added by QA to issues that cannot be tested label Mar 8, 2021
@gabrielluong gabrielluong added this to the 88 milestone Mar 9, 2021
@mcarare mcarare closed this as completed Mar 9, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@mcarare @pkirakosyan
For mozilla-mobile#17971: Add Reader view appearance controls in thre…
8f95670 
…e-dot main menu.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
E1 Estimation Point: trivial, less than half day eng:qa:not-needed Added by QA to issues that cannot be tested Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:ReaderMode MR1 Issues that are needed for the MR1 2021 release.
Projects
None yet
Milestone
88
Development

No branches or pull requests
6 participants
@violasong @gabrielluong @eliserichards @bifleming @mcarare @amedyne