Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Feature] Reorder New Tab three-dot menu and add navigation #17770

Closed
eliserichards opened this issue Feb 2, 2021 · 4 comments · Fixed by #18427
Closed

[Feature] Reorder New Tab three-dot menu and add navigation #17770

eliserichards opened this issue Feb 2, 2021 · 4 comments · Fixed by #18427
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:not-needed Added by QA to issues that cannot be tested Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Milestone

Comments

@eliserichards
Copy link

eliserichards commented Feb 2, 2021

Meta: #17796
Followup to #17771

UX point of contact: @violasong (Victoria)

Figma designs (bottom right, labeled "Final design"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1

Acceptance criteria

This should be the HomeMenu.kt file


Current (left) vs new design (right)
image. image

┆Issue is synchronized with this Jira Task

@eliserichards eliserichards added Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs labels Feb 2, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 2, 2021
@eliserichards eliserichards removed the needs:triage Issue needs triage label Feb 2, 2021
@eliserichards eliserichards changed the title [Feature] New tab three-dot menu [Feature] Reorder New Tab three-dot menu Feb 3, 2021
@eliserichards eliserichards changed the title [Feature] Reorder New Tab three-dot menu [Feature] Reorder New Tab three-dot menu and add navigation Feb 3, 2021
@kglazko
Copy link
Contributor

kglazko commented Feb 4, 2021

Adding a ticket for UI tests update since this could be a breaking change #17840

@eliserichards eliserichards added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Feb 12, 2021
@kglazko kglazko self-assigned this Feb 17, 2021
@eliserichards eliserichards added the MR1 Issues that are needed for the MR1 2021 release. label Feb 18, 2021
@kglazko
Copy link
Contributor

kglazko commented Feb 19, 2021

@eliserichards @violasong What should we be doing for toggle to desktop in this menu? I only realized while coding it that in the previous PR where this menu is open when a tab is open, we use this private val selectedSession: TabSessionState? get() = store.state.selectedTab which makes me wonder what to do when there's no selected tab.

kglazko pushed a commit to kglazko/fenix that referenced this issue Feb 20, 2021
@eliserichards eliserichards added the E3 Estimation Point: average, 2 - 3 days label Feb 23, 2021
@violasong
Copy link
Collaborator

Sorry for the delay on this!

Nothing needs to happen (visually) on the new tab page when tapping the Desktop toggle. It should just set it up for the next page(s) loaded.

CCing @vesta to double-check that adding a desktop view toggle to the homescreen menu still sounds good. (@kbrosnan suggested it can be helpful to be able to set this toggle before loading a page.)

@eliserichards eliserichards removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Mar 4, 2021
@eliserichards
Copy link
Author

@kglazko I broke out the implementation of desktop site into another story, if you want to just add the item in this PR: #17800

eliserichards pushed a commit that referenced this issue Mar 31, 2021
* Create new menu order for new tab

* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.

* Lint

Lint and refactoring tests

* Tests for default toolbar menu

* Feature flag for request desktop site

Add todos for UI test issue 17979

Add todos for UI tests
@eliserichards eliserichards added the eng:qa:not-needed Added by QA to issues that cannot be tested label Mar 31, 2021
@gabrielluong gabrielluong added this to the 89 milestone Apr 1, 2021
@eliserichards eliserichards linked a pull request Apr 6, 2021 that will close this issue
3 tasks
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:not-needed Added by QA to issues that cannot be tested Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants