-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Feature] Reorder New Tab three-dot menu and add navigation #17770
Comments
Adding a ticket for UI tests update since this could be a breaking change #17840 |
@eliserichards @violasong What should we be doing for toggle to desktop in this menu? I only realized while coding it that in the previous PR where this menu is open when a tab is open, we use this |
Sorry for the delay on this! Nothing needs to happen (visually) on the new tab page when tapping the Desktop toggle. It should just set it up for the next page(s) loaded. CCing @vesta to double-check that adding a desktop view toggle to the homescreen menu still sounds good. (@kbrosnan suggested it can be helpful to be able to set this toggle before loading a page.) |
* Create new menu order for new tab * Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent. * Lint Lint and refactoring tests * Tests for default toolbar menu * Feature flag for request desktop site Add todos for UI test issue 17979 Add todos for UI tests
Meta: #17796
Followup to #17771
UX point of contact: @violasong (Victoria)
Figma designs (bottom right, labeled "Final design"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1
Acceptance criteria
This should be the
HomeMenu.kt
fileCurrent (left) vs new design (right)
.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: