Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Tab counter long-press menu: re-arrange items so "New tab" is always under finger #11677

Closed
Cheap-Skate opened this issue Jun 17, 2020 · 5 comments · Fixed by #11957
Closed
Assignees

Comments

@Cheap-Skate
Copy link

Cheap-Skate commented Jun 17, 2020

What is the user problem or growth opportunity you want to see solved?

Long press on tab counter brings up context menu - which is great. But ATM the item order is not ideal. I think New Tab is the most likely menu item to be used. I think therefore New Tab should always be under the user's finger straight after the long press. Then I can go long-press; tap in the same area of the screen to open a new tab.

How do you know that this problem exists today? Why is this important?

ATM I have to long press the tab counter then look hard to find the New Tab context menu item, move my finger to it, and then tap.

Plus the menu item under my finger is different with top toolbar (close tab) and with bottom toolbar (New private tab).

So I think the menu order should be

Bottom toolbar:-
Close tab
New private tab
New tab

Top toolbar:-
New tab
New private tab
Close tab

Who will benefit from it?

All users will be able to, without looking, long-press then tap the tab counter to open a new (non-private) tab.

Thanks!

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 17, 2020
@person808
Copy link
Contributor

person808 commented Jun 24, 2020

The feature is pretty much a copy of chrome's implementation which is

Close tab
New tab
New private tab

You're right that the order of menu items relative to the user's finger changes depending on the toolbar position. Will wait for UX feedback on the menu item order

@person808 person808 added the needs:UX-feedback Needs UX Feedback label Jun 24, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jun 24, 2020

This makes sense to me. @apbitner to confirm menu order.

@apbitner
Copy link

Agreed 👍🏻

@apbitner apbitner removed the needs:UX-feedback Needs UX Feedback label Jun 25, 2020
@person808 person808 self-assigned this Jun 25, 2020
@person808 person808 added Feature:Tabs and removed needs:triage Issue needs triage labels Jun 25, 2020
person808 added a commit to person808/fenix that referenced this issue Jun 25, 2020
person808 added a commit to person808/fenix that referenced this issue Jun 25, 2020
person808 added a commit to person808/fenix that referenced this issue Jun 25, 2020
person808 added a commit to person808/fenix that referenced this issue Jun 25, 2020
@person808 person808 added the eng:qa:needed QA Needed label Jun 25, 2020
@person808
Copy link
Contributor

reopening for qa

@person808 person808 reopened this Jun 25, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 06/26 with Xiaomi Redmi Note 8T (Android 9) and LG G7 FIT (Android 8).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 26, 2020
@liuche liuche mentioned this issue Jun 27, 2020
12 tasks
@data-sync-user data-sync-user changed the title Tab counter long-press menu: re-arrange items so "New tab" is always under finger FNX2-16613 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16613 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger FNX3-14817 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14817 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger FNX-12654 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12654 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger FNX2-16613 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16613 ⁃ Tab counter long-press menu: re-arrange items so "New tab" is always under finger Tab counter long-press menu: re-arrange items so "New tab" is always under finger May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants