Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Cant take screenshot in PWA or Custom tabs #11534

Closed
s-ankur opened this issue Jun 12, 2020 · 5 comments
Closed

[Bug] Cant take screenshot in PWA or Custom tabs #11534

s-ankur opened this issue Jun 12, 2020 · 5 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:CustomTabs Feature:PrivateBrowsing Feature:PWA Progressive Web App
Milestone

Comments

@s-ankur
Copy link
Contributor

s-ankur commented Jun 12, 2020

Steps to reproduce

Set allow screenshots in private browsing to off
Open PB mode in fenix
Leave fenix, open pwa or custom ta

Expected behavior

Can take screenshot. PWA cannot be in PB

Actual behavior

Can't take screenshot

Device information

  • Android device: Asus zenfone
  • Fenix version: fenix nightly

┆Issue is synchronized with this Jira Task

@s-ankur s-ankur added the 🐞 bug Crashes, Something isn't working, .. label Jun 12, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 12, 2020
@sheikh-azharuddin
Copy link

Also while closing the private mode from notification panel the pwa screen also closing

@ekager ekager added Feature:CustomTabs Feature:PrivateBrowsing Feature:PWA Progressive Web App eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Jun 12, 2020
@kbrosnan
Copy link
Contributor

You should be able to change the Allow screenshots in private browsing toggle to true to enable this behavior in the Private Browsing section of the settings. It changed last week to disable screenshots by by default.

@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 13, 2020

Maybe this this toggle should be renamed or get a description to make it clear that it affects PWAs and Custom Tabs, too? I never would have thought that this option affects PWAs and Custom Tabs.

@s-ankur
Copy link
Contributor Author

s-ankur commented Jun 13, 2020

@kbrosnan I understand that but the problem is different.
Right now, whether you can take screenshot in PWA depends on if the browser is in private mode or normal mode which makes no sense .
@cadeyrn it would be one thing if the option unconditionally disabled screenshots in pwa and ct but right now it depends on what you are doing in the browser which i think should not affect pwa or ct

@NotWoods NotWoods self-assigned this Jun 19, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 22, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 22, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 22, 2020
@NotWoods NotWoods added the eng:qa:needed QA Needed label Jun 23, 2020
@NotWoods NotWoods added this to the 5.2 milestone Jun 23, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 23, 2020

Hi, verified as fixed on the latest Nightly Build 200623 from 6/23 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200623-150322

@AndiAJ AndiAJ closed this as completed Jun 23, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 23, 2020
@liuche liuche mentioned this issue Jun 27, 2020
12 tasks
@data-sync-user data-sync-user changed the title [Bug] Cant take screenshot in PWA or Custom tabs FNX2-16543 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16543 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs FNX3-14702 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14702 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs FNX-12484 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12484 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs FNX2-16543 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16543 ⁃ [Bug] Cant take screenshot in PWA or Custom tabs [Bug] Cant take screenshot in PWA or Custom tabs May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:CustomTabs Feature:PrivateBrowsing Feature:PWA Progressive Web App
Projects
None yet
Development

No branches or pull requests

8 participants