Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Fenix UI test reports logging success with failures #10611

Closed
AaronMT opened this issue May 12, 2020 · 0 comments · Fixed by #10612
Closed

[Bug] Fenix UI test reports logging success with failures #10611

AaronMT opened this issue May 12, 2020 · 0 comments · Fixed by #10612
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:automation Build automation, Continuous integration, .. needs:triage Issue needs triage

Comments

@AaronMT
Copy link
Contributor

AaronMT commented May 12, 2020

I believe starting with the changes we added in #10089 I am seeing Matrix Results report as failure but logged as success for the past couple days since this landed.

I think this is happening due to the following

$JAVA_BIN -jar $FLANK_BIN android run \
	--config=$flank_template \
	--max-test-shards=$num_shards \
	--app=$APK_APP --test=$APK_TEST \
	--local-result-dir="${RESULTS_DIR}" \
	--project=$GOOGLE_PROJECT \
	| tee flank.log

exitcode=$?
failure_check

I believe the tee call is overwriting the exit check we want from calling Flank just prior 🙃

┆Issue is synchronized with this Jira Task

@AaronMT AaronMT added the 🐞 bug Crashes, Something isn't working, .. label May 12, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 12, 2020
@AaronMT AaronMT added the eng:automation Build automation, Continuous integration, .. label May 12, 2020
AaronMT added a commit to AaronMT/fenix that referenced this issue May 12, 2020
AaronMT added a commit to AaronMT/fenix that referenced this issue May 13, 2020
AaronMT added a commit to AaronMT/fenix that referenced this issue May 13, 2020
AaronMT added a commit to AaronMT/fenix that referenced this issue May 14, 2020
@liuche liuche mentioned this issue May 19, 2020
32 tasks
@data-sync-user data-sync-user changed the title [Bug] Fenix UI test reports logging success with failures FNX2-16046 ⁃ [Bug] Fenix UI test reports logging success with failures Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16046 ⁃ [Bug] Fenix UI test reports logging success with failures FNX-4767 ⁃ [Bug] Fenix UI test reports logging success with failures Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4767 ⁃ [Bug] Fenix UI test reports logging success with failures FNX3-14027 ⁃ [Bug] Fenix UI test reports logging success with failures Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14027 ⁃ [Bug] Fenix UI test reports logging success with failures FNX2-16046 ⁃ [Bug] Fenix UI test reports logging success with failures Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX2-16046 ⁃ [Bug] Fenix UI test reports logging success with failures FNX-4767 ⁃ [Bug] Fenix UI test reports logging success with failures Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4767 ⁃ [Bug] Fenix UI test reports logging success with failures [Bug] Fenix UI test reports logging success with failures May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:automation Build automation, Continuous integration, .. needs:triage Issue needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants