Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Tapping on the example link from Add search engine opens the support page #10551

Closed
sv-sdeiac opened this issue May 11, 2020 · 7 comments
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sv-sdeiac
Copy link

sv-sdeiac commented May 11, 2020

Steps to reproduce

  1. Go to settings;
  2. Select "Add search engine" from "Search" option;
  3. Select "Other";
  4. Tap on the example link.

Expected behavior

Nothing happens when you tap on the example link.

Actual behavior

The support page from the "Learn more" hyperlink is opened.

Device information

Android device:

  • Google Pixel 3 (Android 10);
  • Samsung Galaxy Note 8 (Android 9);
  • LG G7 fit (Android 8.1).
  • Fenix version: Firefox Preview Nightly 5/11 #21320625.

20200511UNITO-UNDERSCORE!111400!

┆Issue is synchronized with this Jira Task

@sv-sdeiac sv-sdeiac added 🐞 bug Crashes, Something isn't working, .. Feature:Settings S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels May 11, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 11, 2020
@ekager ekager removed the needs:triage Issue needs triage label May 12, 2020
@ekager
Copy link
Contributor

ekager commented May 12, 2020

The Learn More support link has a larger touch target that is covering the example link. We should check with UX to see if we should change anything here.

@ekager ekager added the needs:UX-feedback Needs UX Feedback label May 12, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jun 2, 2020

@brampitoyo for feedback

@brampitoyo
Copy link

@ekager @sv-sdeiac I think that the touch target should only cover the “Learn more” link, so if you tap anywhere else on that paragraph of text, nothing would happen.

@brampitoyo brampitoyo removed the needs:UX-feedback Needs UX Feedback label Jun 16, 2020
@ValentinTimisica ValentinTimisica self-assigned this Jun 22, 2020
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Jun 22, 2020
@ValentinTimisica
Copy link
Contributor

Reopening for QA.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 23, 2020

Hi, I've just checked this matter on the latest Nightly Build 200623 from 6/23 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

It seems that the touch target still covers more than the “Learn more” link,
Tapping bellow or left side opens the link in a new tab

► Video
20200623-093630

@brampitoyo - Please review and share your thoughts ☺️
I'll remove the QA needed label

@AndiAJ AndiAJ closed this as completed Jun 23, 2020
@AndiAJ AndiAJ reopened this Jun 23, 2020
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Jun 23, 2020
@mcarare
Copy link
Contributor

mcarare commented Jun 23, 2020

I have discussed this with @AndiAJ . The behavior described is an a11y change I implemented, because the touch target for the learn more link would have been reported as too small by the accessibility scanner. The change follows the UX decision: "if you tap anywhere else on that paragraph of text, nothing would happen." Tapping anywhere on other text does not trigger the link, only tapping on the link row or in an a11y area of 48 height around the link.

I am closing this. @brampitoyo if you consider this not ok, please feel free to reopen and share your decision. TY!

@mcarare mcarare closed this as completed Jun 23, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 23, 2020

In this case, verified as fixed on the latest Nightly Build 200623 from 6/23 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200623-093053

@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Jun 23, 2020
@liuche liuche mentioned this issue Jun 27, 2020
12 tasks
@data-sync-user data-sync-user changed the title [Bug] Tapping on the example link from Add search engine opens the support page FNX2-16018 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16018 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page FNX-4374 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4374 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page FNX3-13981 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13981 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page FNX-4374 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4374 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page FNX2-16018 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16018 ⁃ [Bug] Tapping on the example link from Add search engine opens the support page [Bug] Tapping on the example link from Add search engine opens the support page May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

No branches or pull requests

8 participants