Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Crash on Rapid selection of "Tabs" and three dot menu #10408

Closed
s-ankur opened this issue May 4, 2020 · 3 comments
Closed

[Bug] Crash on Rapid selection of "Tabs" and three dot menu #10408

s-ankur opened this issue May 4, 2020 · 3 comments
Assignees
@mcarare
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs Feature:Toolbar Address bar, see also Feature:Search

Comments

@s-ankur
Copy link
Contributor

s-ankur commented May 4, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

Quickly tap on on tabs and three dot menu while a webpage is open
Wrong type of three dot menu appears in the overview
ScreenshotUNITO-UNDERSCORE!20200504-235503!UNITO-UNDERSCORE!Firefox!UNITO-UNDERSCORE!Nightly!

Click on any button and firfox crashes

Device information

  • Android device: Asus Zenfone
  • Fenix version: Fenix Nightly

┆Issue is synchronized with this Jira Task
@s-ankur s-ankur added the 🐞 bug Crashes, Something isn't working, .. label May 4, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 4, 2020
@s-ankur
Copy link
Contributor Author

s-ankur commented May 4, 2020 •
edited
Loading

Doing the same with the sheild icon and the tabs button directly crashes firefox

@eliserichards eliserichards added Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs Feature:Toolbar Address bar, see also Feature:Search and removed needs:triage Issue needs triage labels May 4, 2020
@eliserichards eliserichards added the b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info label May 4, 2020
mcarare added a commit to mcarare/fenix that referenced this issue May 5, 2020
@mcarare
For mozilla-mobile#10408: Check current destination before navigating.
bfc58cb
@mcarare mcarare mentioned this issue May 5, 2020
Merged
4 tasks
mcarare added a commit to mcarare/fenix that referenced this issue May 5, 2020
@mcarare
For mozilla-mobile#10408: Dismiss menu when navigating away.
bdd4a6b 
The menu is dismissed when toolbar view is detached from window.
@mcarare mcarare self-assigned this May 5, 2020
mcarare added a commit to mcarare/fenix that referenced this issue May 5, 2020
@mcarare
For mozilla-mobile#10408: Dismiss menu when navigating away.
9c60829 
The menu is dismissed when toolbar view is detached from window.
mcarare added a commit to mcarare/fenix that referenced this issue May 5, 2020
@mcarare
For mozilla-mobile#10408: Dismiss menu when navigating away.
eabb206 
The menu is dismissed when toolbar view is detached from window.
sblatz pushed a commit that referenced this issue May 5, 2020
@mcarare
For #10408: Dismiss menu when navigating away. (#10415)
5106134 
The menu is dismissed when toolbar view is detached from window.
@sblatz sblatz added the eng:qa:needed QA Needed label May 5, 2020
@abodea
Copy link
Member

abodea commented May 6, 2020

I re-checked this issue on the latest Nightly from 5/6 with Google Pixel 4 XL (10).
Note that the 3 dot menu is still displayed on the home screen, but the PR for that is not merged. I will confirm this issue once that issue is fixed too.

mcarare added a commit that referenced this issue May 7, 2020
@mcarare
For #10408: Check current destination before navigating.
9177871
@abodea
Copy link
Member

abodea commented May 7, 2020 •
edited
Loading

Verified as fixed on the latest Nightly 5/7 with Google Pixel 4 XL (10).

@abodea abodea closed this as completed May 7, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 7, 2020
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@data-sync-user data-sync-user changed the title [Bug] Crash on Rapid selection of "Tabs" and three dot menu FNX2-15933 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15933 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu FNX-3521 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3521 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu FNX3-13876 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13876 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu FNX2-15933 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX2-15933 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu FNX-3521 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-3521 ⁃ [Bug] Crash on Rapid selection of "Tabs" and three dot menu [Bug] Crash on Rapid selection of "Tabs" and three dot menu May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs Feature:Toolbar Address bar, see also Feature:Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sblatz @s-ankur @abodea @eliserichards @mcarare @data-sync-user